From a2e3d9271d6e2d2add0f5b4a47b626f6ceea59a8 Mon Sep 17 00:00:00 2001 From: codygunton Date: Wed, 5 Apr 2023 16:10:20 -0400 Subject: [PATCH] Add todo comments. --- cpp/src/barretenberg/honk/CMakeLists.txt | 1 + .../composer/composer_helper/standard_honk_composer_helper.hpp | 1 + cpp/src/barretenberg/proof_system/types/composer_type.hpp | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/cpp/src/barretenberg/honk/CMakeLists.txt b/cpp/src/barretenberg/honk/CMakeLists.txt index df60576b16..924f91faa6 100644 --- a/cpp/src/barretenberg/honk/CMakeLists.txt +++ b/cpp/src/barretenberg/honk/CMakeLists.txt @@ -1,3 +1,4 @@ +# TODO(Cody): Make remove plonk dependency barretenberg_module(honk numeric ecc srs proof_system transcript plonk) if(TESTING) diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp index 613daaf6a1..5b033996d5 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp @@ -29,6 +29,7 @@ template class StandardHonkComposerHelper { // at all std::shared_ptr crs_factory_; bool computed_witness = false; + // TODO(Luke): use make_shared StandardHonkComposerHelper() : StandardHonkComposerHelper(std::shared_ptr( new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) diff --git a/cpp/src/barretenberg/proof_system/types/composer_type.hpp b/cpp/src/barretenberg/proof_system/types/composer_type.hpp index 3521715cd4..295967e136 100644 --- a/cpp/src/barretenberg/proof_system/types/composer_type.hpp +++ b/cpp/src/barretenberg/proof_system/types/composer_type.hpp @@ -1,6 +1,6 @@ #pragma once namespace proof_system { -// This will go away, but we move it here has a temporary measure to make proof_system not depend on honk or plonk. +// TODO(Cody) Get rid of this. enum ComposerType { STANDARD, TURBO, PLOOKUP, STANDARD_HONK }; } // namespace proof_system \ No newline at end of file