-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize usage of namespaces & includes #190
Comments
My 2cents is C++ is fine without namespaces at all, and one for a library is polite but I find nested namespaces voluntary fiction that I usually choose not to do. But C++ is notoriously opinionated in practice so I respect the group decision |
As part of this PR, remove all cases of using-entire-namespace ( When this PR is done, the following |
E.g. there are several confusing namespaces being used in the base rollup files. Perhaps we could get away with a single namespace (Edit: for base rollup)?
Ideally, the namespace structure (and naming) should match the directory structure (and naming).
The text was updated successfully, but these errors were encountered: