Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize usage of namespaces & includes #190

Closed
iAmMichaelConnor opened this issue Apr 7, 2023 · 2 comments
Closed

Standardize usage of namespaces & includes #190

iAmMichaelConnor opened this issue Apr 7, 2023 · 2 comments
Labels
refactor Refactoring
Milestone

Comments

@iAmMichaelConnor
Copy link
Contributor

iAmMichaelConnor commented Apr 7, 2023

E.g. there are several confusing namespaces being used in the base rollup files. Perhaps we could get away with a single namespace (Edit: for base rollup)?
Ideally, the namespace structure (and naming) should match the directory structure (and naming).

@ludamad
Copy link
Contributor

ludamad commented Apr 7, 2023

My 2cents is C++ is fine without namespaces at all, and one for a library is polite but I find nested namespaces voluntary fiction that I usually choose not to do. But C++ is notoriously opinionated in practice so I respect the group decision

@iAmMichaelConnor iAmMichaelConnor added the refactor Refactoring label Apr 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 8, 2023
@dbanks12 dbanks12 changed the title Tidy the namespaces Standardize usage of namespaces Apr 11, 2023
@dbanks12 dbanks12 changed the title Standardize usage of namespaces Standardize usage of namespaces & includes Apr 25, 2023
@dbanks12
Copy link
Contributor

dbanks12 commented Apr 29, 2023

As part of this PR, remove all cases of using-entire-namespace (using namespace <MYNAMESPACE>;) which leads to pollution.

When this PR is done, the following WarningsAsErrors omissions should be removed from .clang-tidy which will promote this deviation from our standard to an error: -google-build-using-namespace, (config here and remove/update comments here and here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring
Projects
None yet
Development

No branches or pull requests

3 participants