Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change empty leaf of the nullifier tree #161

Closed
LHerskind opened this issue Apr 4, 2023 · 1 comment
Closed

Change empty leaf of the nullifier tree #161

LHerskind opened this issue Apr 4, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@LHerskind
Copy link
Contributor

Implement the successor merkle tree for nullifiers in the base with batch insertion. There are double-spend issues if using batch insertion as in normal merkle tree which need to be addressed in this separately.

The double-spend case is when the same predecessor is to be updated multiple times, such that one of the pending should have a predecessor in the pending set and not outside. Also need to address the 0 leaf insertions and not use empty leafs as base as it is possible to point an empty leaf to anything creating a "split" in the tree.

@LHerskind LHerskind converted this from a draft issue Apr 4, 2023
@iAmMichaelConnor iAmMichaelConnor added the bug Something isn't working label Apr 8, 2023
@Maddiaa0 Maddiaa0 moved this from Todo to In Progress in A3 Apr 11, 2023
@iAmMichaelConnor iAmMichaelConnor changed the title Nullifier logic - Base Rollup Circuit Change empty leaf of the nullifier tree Apr 11, 2023
@Maddiaa0 Maddiaa0 moved this from In Progress to In Review in A3 Apr 18, 2023
@Maddiaa0 Maddiaa0 moved this from In Review to Done in A3 Apr 19, 2023
@iAmMichaelConnor
Copy link
Contributor

Closing because moved to 'Done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants