chore: Move epoch and slot durations to config #9861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
palla/durations-as-config
branch
from
e0667b2
to
1ace8f2
Compare
spalladino
force-pushed
the
palla/durations-as-config
branch
2 times, most recently
from
098611a
to
52ba943
Compare
just-mitch
added
the
hotfix
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
spalladino
force-pushed
the
palla/durations-as-config
branch
2 times, most recently
from
3cb4633
to
56519b1
Compare
De-enshrines the following constants and turns them into config: ``` ETHEREUM_SLOT_DURATION = 12; AZTEC_SLOT_DURATION = 24; AZTEC_EPOCH_DURATION = 16; AZTEC_TARGET_COMMITTEE_SIZE = 48; AZTEC_EPOCH_PROOF_CLAIM_WINDOW_IN_L2_SLOTS = 13; ``` These can now be set via env vars. On L1, they are set as immutable variables across all contracts that require them. As for circuits, none of them was needed, except for the epoch duration to be able to dimension the fees array. This was handled by introducing a new MAX_EPOCH_DURATION constant (32) which sets the max length of the array. This is a prerequisite to #9809
spalladino
force-pushed
the
palla/durations-as-config
branch
from
a3307e7
to
c2a6128
Compare
TomAFrench
added a commit
that referenced
this pull request
Nov 11, 2024
* master: (182 commits) feat(avm): mem specific range check (#9828) refactor: remove public kernel inner (#9865) chore: Revert "chore: Validate RPC inputs" (#9875) Revert "fix: deploy l2 contracts fails on 48 validator" (#9871) fix: deploy l2 contracts fails on 48 validator (#9860) chore: Validate RPC inputs (#9672) fix: fixing devcontainers to use the sandbox docker-compose file (#9782) fix: Revert changes to ci.yml (#9863) chore: Move epoch and slot durations to config (#9861) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: tree heights that last past 3 days (#9760) fix(build): l1-contracts .rebuild_patterns did not cover test files (#9862) fix: bench prover test (#9856) fix: Fix mac build by calling `count` on durations (#9855) feat: zk shplemini (#9830) feat: domain separate block proposals and attestations (#9842) chore: bump runner cache disk size (#9849) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De-enshrines the following constants and turns them into config:
These can now be set via env vars. On L1, they are set as immutable variables across all contracts that require them. As for circuits, none of them was needed, except for the epoch duration to be able to dimension the fees array. This was handled by introducing a new MAX_EPOCH_DURATION constant (32) which sets the max length of the array.
This is a prerequisite to #9809