feat: updating archiver with new inbox

[benesjan]

Fixes #4828

[benesjan]

• feat: parity circuits #5082
• feat: updating archiver with new inbox #5025 👈
• feat: deploying new inbox #5036
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_successful_decrypting_time_in_ms (5): 1,502 (+19%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d483e678 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,492	239,348	470,384
l1_rollup_execution_gas	673,955	980,169	1,389,158
l2_block_processing_time_in_ms	1,361 (+4%)	4,739	9,467 (+6%)
note_successful_decrypting_time_in_ms	154 (+7%)	539 (+10%)	1,011 (+3%)
note_trial_decrypting_time_in_ms	63.3 (+33%)	56.0 (-46%)	134 (+17%)
l2_block_building_time_in_ms	12,264 (+2%)	48,507 (+2%)	96,857 (+1%)
l2_block_rollup_simulation_time_in_ms	7,544 (+3%)	29,930 (+2%)	59,800 (+2%)
l2_block_public_tx_process_time_in_ms	4,688	18,489 (+1%)	36,902

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,506 (-14%)	28,267 (+7%)
note_history_successful_decrypting_time_in_ms	⚠️ 1,502 (+19%)	2,445 (+2%)
note_history_trial_decrypting_time_in_ms	153 (+49%)	145 (-12%)
node_database_size_in_bytes	18,858,064	35,377,232 (-1%)
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	251	44,736	28,001
private-kernel-ordering	195	52,625	14,627
base-rollup	671 (+1%)	177,932	997
root-rollup	69.0 (-4%)	4,320	825
private-kernel-inner	319	73,715	28,001
public-kernel-app-logic	163 (-1%)	34,920	27,972
public-kernel-tail	81.7	34,507	27,972
merge-rollup	8.58 (-4%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.82 (-5%)	10.5 (+3%)	12.4 (+2%)	16.2 (-4%)	22.4 (+2%)	35.9 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.569 (-5%)	0.580 (+3%)	0.526 (+2%)	0.501 (-4%)	0.466 (+1%)	0.446 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	46.1 (-5%)	72.3 (+2%)	232 (+1%)	447 (-3%)	870 (+1%)	1,746 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.471 (-5%)	0.445 (+1%)	0.423 (+1%)	0.417 (-4%)	0.414 (+1%)	0.417 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	55.7 (-2%)	107 (+1%)	337	663 (-4%)	1,317 (+1%)	2,631 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.492 (-3%)	0.482 (+1%)	0.458	0.455 (-4%)	0.456 (+1%)	0.455
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.6 (-4%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.537 (-4%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,650

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,806 (+3%)	1,384 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	7.73 (+3%)	574

[benesjan]

This ^ is the least annoying way of getting the new inbox address. Once the old inbox is purged the new inbox address will be passed config.l1Contracts.inboxAddress as well.

BTW I feel like having all these addresses passed via config is quite shit and it would be better to just pass registry address and fetch the rest from chain.

[benesjan]

The naming here is stupid but I will clean that up when doing the purge.

[benesjan]

I was looking for the constant and found out that the constant name here was incorrect so I fixed that.

[sklppy88]

👍, random comments on names, but nothing blocking / critical

[sklppy88]

Is newMessages the best name we can use here ? Would newL1toL2Messages be an improvement ?

[benesjan]

Sounds good. Will tackle that during purge.

[sklppy88]

Sheesh 😅

[sklppy88]

Imo the general nomenclature of using only the event name is not great. What if we have the same event name for another contract ? Maybe we should consider Contract Name + Event Type.

i.e. processInboxLeafInsertedLogs

[benesjan]

I think just using the event name would be fine if we have a good event name. "LeafInserted" is not descriptive out of inbox. I plan on renaming it once I do the old messaging purge.