From 840eb82d5fc39e3918d1db4e043885e74cbc8a10 Mon Sep 17 00:00:00 2001
From: ludamad <adam.domurad@gmail.com>
Date: Mon, 11 Sep 2023 14:22:04 -0400
Subject: [PATCH] fix: reinstate v stripping

Phil notified that we intent to strip the leading v when passing to docker build
---
 build-system/scripts/build | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/build-system/scripts/build b/build-system/scripts/build
index 7cd9c5a6cc3..0dde9ea4945 100755
--- a/build-system/scripts/build
+++ b/build-system/scripts/build
@@ -135,13 +135,9 @@ if [[ -n "$COMMIT_TAG" ]]; then
     COMMIT_TAG_VERSION=$COMMIT_TAG
   fi
 
-  ## We are building a tagged commit. Check it's a valid semver.
-  #VERSION=$(npx semver $COMMIT_TAG_VERSION)
-  #if [ -z "$VERSION" ]; then
-  #  COMMIT_TAG_VERSION=""
-  #else
-  #  COMMIT_TAG_VERSION=$VERSION
-  #fi
+  # We are building a tagged commit. 
+  # We prefer to strip the leading 'v' (if it exists) from versions when passing to docker.
+  COMMIT_TAG_VERSION=${COMMIT_TAG_VERSION#v}
 else
   COMMIT_TAG_VERSION=""
 fi