Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blobs): revert to constant roots of unity rather than unconstrained #9982

Open
Tracked by #8955
MirandaWood opened this issue Nov 15, 2024 · 1 comment
Open
Tracked by #8955
Assignees
Labels
team-turing Leila's team

Comments

@MirandaWood
Copy link
Contributor

MirandaWood commented Nov 15, 2024

Due to noir-lang/noir#6457, having a huge constants file with the roots of unity is slowing down noir/proving/simulating in the blobs PR (#9302). With this slowdown, proving 3 blobs per block instead of 1 won't run, but 1 isn't enough to contain the fields we expect.

For now, we are calculating the roots of unity in an unconstrained function and using those to move to 3 blobs. This means we are not constraining that we have correctly constructed a blob containing the tx effects of the block, so it's horribly insecure.

Once the above issues are resolve, go back to using the large constants file in noir-projects/noir-protocol-circuits/crates/blob/src/config.nr and delete noir-projects/noir-protocol-circuits/crates/blob/src/unconstrained_config.nr.

@MirandaWood MirandaWood added the team-turing Leila's team label Nov 15, 2024
@MirandaWood MirandaWood changed the title Blobs: revert to constant roots unity rather than unconstrained Blobs: revert to constant roots of unity rather than unconstrained Nov 15, 2024
@MirandaWood MirandaWood changed the title Blobs: revert to constant roots of unity rather than unconstrained feat(blobs): revert to constant roots of unity rather than unconstrained Nov 30, 2024
@TomAFrench
Copy link
Member

The linked issue has been closed, is this still a problem today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-turing Leila's team
Projects
None yet
Development

No branches or pull requests

2 participants