You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #9623 we saw the need to call getTxEffect while processing logs in order to know the note hashes (new commitments) in a given tx hash, and therefore find the nonce of a note. This results in quite a few roundtrips to the node - it may be better to return the new comittments along with the tx hash in getLogsByTag, since that information is always required in order to perform the task getLogsByTag is designed for.
The text was updated successfully, but these errors were encountered:
A partial solution to this was implemented in #9794. TxEffects are cached now, since it's sensible to assume we'll have a lot of logs from the same transaction during a sync
In #9623 we saw the need to call
getTxEffect
while processing logs in order to know the note hashes (new commitments) in a given tx hash, and therefore find the nonce of a note. This results in quite a few roundtrips to the node - it may be better to return the new comittments along with the tx hash ingetLogsByTag
, since that information is always required in order to perform the taskgetLogsByTag
is designed for.The text was updated successfully, but these errors were encountered: