Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bundling tx effects in getLogsByTag #9789

Open
Tracked by #9119
nventuro opened this issue Nov 6, 2024 · 1 comment
Open
Tracked by #9119

Consider bundling tx effects in getLogsByTag #9789

nventuro opened this issue Nov 6, 2024 · 1 comment
Labels
C-node Component: Aztec Node team-fairies Nico's team

Comments

@nventuro
Copy link
Contributor

nventuro commented Nov 6, 2024

In #9623 we saw the need to call getTxEffect while processing logs in order to know the note hashes (new commitments) in a given tx hash, and therefore find the nonce of a note. This results in quite a few roundtrips to the node - it may be better to return the new comittments along with the tx hash in getLogsByTag, since that information is always required in order to perform the task getLogsByTag is designed for.

@Thunkar
Copy link
Contributor

Thunkar commented Nov 14, 2024

A partial solution to this was implemented in #9794. TxEffects are cached now, since it's sensible to assume we'll have a lot of logs from the same transaction during a sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-node Component: Aztec Node team-fairies Nico's team
Projects
None yet
Development

No branches or pull requests

2 participants