Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Constrain App function VKs #9756

Merged
merged 23 commits into from
Nov 7, 2024
Merged

Conversation

sirasistant
Copy link
Collaborator

@sirasistant sirasistant commented Nov 5, 2024

Resolves #9592

  • Now contract artifacts must have VKs in their private functions
  • aztec-nargo inserts the verification keys after public function transpilation
  • We no longer derive any VK in the TX proving flow
  • App VKs are now constrained in the private kernels
  • Bootstrap generates VKs for all apps (with s3 caching)
  • PXE is currently accepting any VK present in the artifact as valid: we should explore the correct interface for this in the future and wether PXE can use those VKs without rederiving them from ACIR

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Changes to circuit sizes

Generated at commit: f8ba6b6eac1aeabfd66919700ee0bf734bddbd15, compared to commit: 2509e2f132d30efa5085e9740279529ce551215a

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init +190 ❌ +0.88% +3,837 ❌ +12.34%
private_kernel_inner +189 ❌ +0.50% +3,836 ❌ +7.14%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 21,748 (+190) +0.88% 34,933 (+3,837) +12.34%
private_kernel_inner 38,127 (+189) +0.50% 57,586 (+3,836) +7.14%

@sirasistant sirasistant added the e2e-all CI: Enables this CI job. label Nov 5, 2024
@sirasistant sirasistant requested a review from LeilaWang November 6, 2024 15:07
@sirasistant sirasistant changed the title feat: Constrain App function VKs (WIP) feat: Constrain App function VKs Nov 6, 2024
Copy link
Collaborator

@LeilaWang LeilaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!! 🚀

@@ -115,7 +115,7 @@ impl AztecAddress {

pub fn compute_from_private_function(
function_selector: FunctionSelector,
functino_vk_hash: Field,
function_vk_hash: Field,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😂

@sirasistant
Copy link
Collaborator Author

Removing e2e-all since it's triggering a bug present on master

@sirasistant sirasistant removed the e2e-all CI: Enables this CI job. label Nov 7, 2024
@sirasistant sirasistant merged commit ae7cfe7 into master Nov 7, 2024
67 checks passed
@sirasistant sirasistant deleted the arv/constrain_app_vks_alt branch November 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constrain hashing of function circuit VKs.
2 participants