Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to limit fetched logs by single tag #9333

Open
Tracked by #9119
nventuro opened this issue Oct 22, 2024 · 0 comments
Open
Tracked by #9119

Provide a way to limit fetched logs by single tag #9333

nventuro opened this issue Oct 22, 2024 · 0 comments
Labels
A-security Area: Relates to security. Something is insecure. C-node Component: Aztec Node team-fairies Nico's team

Comments

@nventuro
Copy link
Contributor

nventuro commented Oct 22, 2024

Since there's no enshrining of any kind on a log tag is computed (#9268), and no e.g. protocol-enforced siloing, any application can emit whatever tag they desire with any log. This means there can be arbitrarily many logs associated with a given tag, and therefore returned from the getLogsByTag call.

Certain components may require limiting the amount of received logs (e.g. the aztec-nr oracle, due to Noir array limitations), and it'd be good to in general be able to deal with upper bounds on the array size. Therefore we need to have some way to read these tagged logs with some kind of e.g. pagination mechanism, to prevent arbitrarily large responses but still be able to properly process them.

As a stop-gap measure, it might be good enough to simply return the first e.g. 20 logs associated with a given tag and ignore the rest. This does however introduce the possibility of a malicious actor spamming the network with a known tag (e.g. one it sees on the mempool), preventing good actors from discovering notes associated with a log if said log is discarded and never processed.

@nventuro nventuro added team-fairies Nico's team C-node Component: Aztec Node A-security Area: Relates to security. Something is insecure. labels Oct 22, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-security Area: Relates to security. Something is insecure. C-node Component: Aztec Node team-fairies Nico's team
Projects
Status: Todo
Development

No branches or pull requests

1 participant