Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(seq)!: disable sequencer and disable validator as one env var, update p2p listen port names #9266

Merged
merged 18 commits into from
Oct 21, 2024
Merged

chore(seq)!: disable sequencer and disable validator as one env var, update p2p listen port names #9266

merged 18 commits into from
Oct 21, 2024

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Oct 17, 2024 •
edited
Loading

Overview

Breaking change as SEQ_DISABLE is removed

The validator and the sequencer are really the same thing in our current configuration, if we disable the validator, we should also disable the sequencer. The validator should always be a sequencer, so there is no need to have different options for each

fixes: #9262

@Maddiaa0 Maddiaa0 requested a review from just-mitch October 17, 2024 11:22
@Maddiaa0 Maddiaa0 changed the title chore(seq)!: disable sequencer and disable validator as one command chore(seq)!: disable sequencer and disable validator as one env var Oct 17, 2024
just-mitch
just-mitch reviewed Oct 21, 2024
View reviewed changes
yarn-project/end-to-end/scripts/native-network/deploy-l2-contracts.sh
echo "Wrote to state/l2-contracts.env to signal completion"

# sleep 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, for me it was killing the wrong tmix pane, I've left it there and alerted Adam

just-mitch
just-mitch reviewed Oct 21, 2024
View reviewed changes
yarn-project/p2p/src/config.ts
@@ -174,12 +174,12 @@ export const p2pConfigMappings: ConfigMappingsType<P2PConfig> = {
...numberConfigHelper(1_000),
},
tcpListenAddress: {
env: 'TCP_LISTEN_ADDR',
env: 'P2P_TCP_LISTEN_ADDR',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. This probably explains why env vars weren't working as expected in the k8s tests- I needed to set both tcp and udp ports to 40400 for discv5 to work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this might explain a number of issues, I'm doing a bit of investigating to see if this explains why everything died without the boot node

@Maddiaa0 Maddiaa0 changed the title chore(seq)!: disable sequencer and disable validator as one env var chore(seq)!: disable sequencer and disable validator as one env var, update p2p listen port names Oct 21, 2024
@Maddiaa0 Maddiaa0 merged commit 367c38c into master Oct 21, 2024
57 checks passed
@Maddiaa0 Maddiaa0 deleted the md/disable-sequencer-validator branch October 21, 2024 12:39
@AztecBot AztecBot mentioned this pull request Oct 21, 2024
Merged
spypsy pushed a commit that referenced this pull request Oct 21, 2024
@AztecBot
chore(master): Release 0.59.0 (#9281)
6ce20e9 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.59.0</summary>

##
[0.59.0](aztec-package-v0.58.0...aztec-package-v0.59.0)
(2024-10-21)


### ⚠ BREAKING CHANGES

* **seq:** disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](#9266))

### Miscellaneous

* **seq:** Disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](#9266))
([367c38c](367c38c))
</details>

<details><summary>barretenberg.js: 0.59.0</summary>

##
[0.59.0](barretenberg.js-v0.58.0...barretenberg.js-v0.59.0)
(2024-10-21)


### Bug Fixes

* Publish readme on bb.js NPM package
([#9303](#9303))
([1d860a8](1d860a8))
</details>

<details><summary>aztec-packages: 0.59.0</summary>

##
[0.59.0](aztec-packages-v0.58.0...aztec-packages-v0.59.0)
(2024-10-21)


### ⚠ BREAKING CHANGES

* **seq:** disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](#9266))

### Bug Fixes

* **docs:** Dapp tutorial edits
([#8695](#8695))
([f95bcff](f95bcff))
* **docs:** Update debugging docs
([#9200](#9200))
([2a4188c](2a4188c))
* Publish readme on bb.js NPM package
([#9303](#9303))
([1d860a8](1d860a8))


### Miscellaneous

* Re-enable test fixed by Native World State
([#9289](#9289))
([3fd1802](3fd1802)),
closes
[#8306](#8306)
* Replace relative paths to noir-protocol-circuits
([ceeab4e](ceeab4e))
* **seq:** Disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](#9266))
([367c38c](367c38c))
</details>

<details><summary>barretenberg: 0.59.0</summary>

##
[0.59.0](barretenberg-v0.58.0...barretenberg-v0.59.0)
(2024-10-21)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 22, 2024
@AztecBot
chore(master): Release 0.59.0 (#9281)
5098f9a 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.59.0</summary>

##
[0.59.0](AztecProtocol/aztec-packages@aztec-package-v0.58.0...aztec-package-v0.59.0)
(2024-10-21)


### ⚠ BREAKING CHANGES

* **seq:** disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](AztecProtocol/aztec-packages#9266))

### Miscellaneous

* **seq:** Disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](AztecProtocol/aztec-packages#9266))
([367c38c](AztecProtocol/aztec-packages@367c38c))
</details>

<details><summary>barretenberg.js: 0.59.0</summary>

##
[0.59.0](AztecProtocol/aztec-packages@barretenberg.js-v0.58.0...barretenberg.js-v0.59.0)
(2024-10-21)


### Bug Fixes

* Publish readme on bb.js NPM package
([#9303](AztecProtocol/aztec-packages#9303))
([1d860a8](AztecProtocol/aztec-packages@1d860a8))
</details>

<details><summary>aztec-packages: 0.59.0</summary>

##
[0.59.0](AztecProtocol/aztec-packages@aztec-packages-v0.58.0...aztec-packages-v0.59.0)
(2024-10-21)


### ⚠ BREAKING CHANGES

* **seq:** disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](AztecProtocol/aztec-packages#9266))

### Bug Fixes

* **docs:** Dapp tutorial edits
([#8695](AztecProtocol/aztec-packages#8695))
([f95bcff](AztecProtocol/aztec-packages@f95bcff))
* **docs:** Update debugging docs
([#9200](AztecProtocol/aztec-packages#9200))
([2a4188c](AztecProtocol/aztec-packages@2a4188c))
* Publish readme on bb.js NPM package
([#9303](AztecProtocol/aztec-packages#9303))
([1d860a8](AztecProtocol/aztec-packages@1d860a8))


### Miscellaneous

* Re-enable test fixed by Native World State
([#9289](AztecProtocol/aztec-packages#9289))
([3fd1802](AztecProtocol/aztec-packages@3fd1802)),
closes
[#8306](AztecProtocol/aztec-packages#8306)
* Replace relative paths to noir-protocol-circuits
([ceeab4e](AztecProtocol/aztec-packages@ceeab4e))
* **seq:** Disable sequencer and disable validator as one env var,
update p2p listen port names
([#9266](AztecProtocol/aztec-packages#9266))
([367c38c](AztecProtocol/aztec-packages@367c38c))
</details>

<details><summary>barretenberg: 0.59.0</summary>

##
[0.59.0](AztecProtocol/aztec-packages@barretenberg-v0.58.0...barretenberg-v0.59.0)
(2024-10-21)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-mitch just-mitch just-mitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator Disabled should disable block building
2 participants
@Maddiaa0 @just-mitch