Use winston for opentelemetry logging

[ludamad]

Winston is very featureful, we should combine the LOG_JSON mode wth our stdout mode which it both supports and get rid of our custom logger, doing any sort of transforms we currently do before hitting winston

[ludamad]

Note @alexghr had thoughts, can you write them here?

[alexghr]

I quite like pino for logging. It logs JSON all the time and is a drop-in replacement for debug (see pino-debug) so we wouldn't have to change any of our logging code (at least initially).

For local logs pino has pino-pretty to pretty print the JSON logs (we'd just have to redefine our start scripts to pipe stdout through pino-pretty).

Pino is supposedly faster than both winston and debug but I haven't tested this myself (pino benchmarks);

Both pino and winston have official OpenTelemetry instrumentation plugins (to capture context and push logs to the collector):

• https://www.npmjs.com/package/@opentelemetry/instrumentation-pino
• https://www.npmjs.com/package/@opentelemetry/instrumentation-winston

CC @spalladino as he had some thoughts on logging too!

[ludamad]

Ah gotcha, well it's pretty trivial to move to Winston too, curious on @spalladino's thoughts too

[ludamad]

Hmm what was the rationale to keep node debugger module?

[ludamad]

@spypsy I'm probably leaning towards redoing this issue as just attaching an opentelemetry plugin for winston so we can point it to the k8s collector URL from the local network tests

[spalladino]

I'm fine with either winston or pino. A feature I wanted from winston when I first introduced it was easy logrotate, used in the sandbox for keeping local logs that users could send to us, but this probably won't be needed in proper node setups, and there seems to be a pino equivalent.

I haven't used pino in the past, but if it checks the boxes in the wishlist I had put together (assuming folks agree with those wishes!), let's go with it.

Hmm what was the rationale to keep node debugger module?

Personally, I'd remove debug altogether, and just have something where we can tweak logging per-namespace easily.