Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shielding and unshielding token contract #878

Closed
Tracked by #843
LHerskind opened this issue Jun 19, 2023 · 1 comment
Closed
Tracked by #843

feat: Shielding and unshielding token contract #878

LHerskind opened this issue Jun 19, 2023 · 1 comment
Assignees
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jun 19, 2023

Extend the non-native noir token contracts such that it is possible for a user to "shield" or "unshield" his funds.

unshield being that funds are moved from notes in balances, the public_balances.

shield being that funds are moved from the public_balances to notes in balances.

A successful implementation should include at least tests where:

  • User deposits privately, then unshields part of the assets and withdraw from public
  • User deposits publicly, then shields part of the assets and withdraw from private

Consider that shielding can happen two ways, it can be a 1-step action, where the new note is inserted directly which leaks the new owner. Or it can be a 2-step action where a note is inserted and then later claimed for spending. Better privacy but worse UX.

Consider looking into the partial claim notes such that shielding can be done using these, making it a 1-step action that does not leak the owner.

@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 19, 2023
@LHerskind LHerskind added the T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). label Jun 19, 2023
@Maddiaa0 Maddiaa0 moved this from Todo to In Review in A3 Jun 28, 2023
@rahul-kothari
Copy link
Contributor

Fixed in #915

@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jul 10, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).
Projects
None yet
Development

No branches or pull requests

2 participants