Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Designated caller asset contract/portal #877

Closed
Tracked by #876 ...
LHerskind opened this issue Jun 19, 2023 · 0 comments · Fixed by #896
Closed
Tracked by #876 ...

feat: Designated caller asset contract/portal #877

LHerskind opened this issue Jun 19, 2023 · 0 comments · Fixed by #896
Assignees
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).

Comments

@LHerskind
Copy link
Contributor

Extend the asset portals with designated callers as referenced in #843.

Designated caller is a standard that portals can decide to use that strive to make composability of L2 -> L1 easier to implement.

In short, a successful implementation should include:

  • Extended portal contract (and noir) that support withdraw with or without designated caller
  • Extra test that:
    • Show that without designated anyone can call
    • With designated only the designated can call
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 19, 2023
@LHerskind LHerskind changed the title feat: Designated caller feat: Designated caller asset contract/portal Jun 19, 2023
@LHerskind LHerskind added the T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). label Jun 19, 2023
@rahul-kothari rahul-kothari moved this from Todo to In Review in A3 Jun 21, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jun 22, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).
Projects
None yet
2 participants