Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize ReqResp resourcing #8458

Open
Tracked by #8077
Maddiaa0 opened this issue Sep 9, 2024 · 0 comments
Open
Tracked by #8077

perf: Optimize ReqResp resourcing #8458

Maddiaa0 opened this issue Sep 9, 2024 · 0 comments
Assignees
Labels
C-p2p Component: peer to peer

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Sep 9, 2024

Overview

As mentioned by @just-mitch in #8434

The current ReqResp implementation cycles through nodes serially, meaning that the timeouts are all dependent on each other. This is by design, as tx requests which often do not care which peer they are engaging with will require some hard timeout so that we do not stall the node.

  • ReqResp work should be non blocking and entirely asynchronous
  • Track how often nodes are asking for data
    • How frequently they are asking
    • How long do the responses take

If we are unable to serve the normal usecase with serial requests, then we will have to parallelize requests among multiple peers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-p2p Component: peer to peer
Projects
Status: Todo
Development

No branches or pull requests

1 participant