refactor: Renaming Instance's

[codygunton]

The main objective of this PR is to do some renaming to stop using the term "instance" as we currently do in the Honk flavors that can be used to construct proofs from stdlib circuits (Mega, UItra, relative). This is bad terminology for several reasons:

• the term "instace-witness pair" is widely in use in ZK, and our existing use of "instance" directly clashes with this.
• ProverInstance is really just a key for Decider proving; similarly for VerifierInstance
• ProvingKey as it currently exists is de facto deprecated in the contexts where we use "instance"'s since we have have rewritten those provers and verifiers using Oink prover and verifier.
• "Prover instance" sounds a lot like an instance of the Prover class--can be confusing in conversation.
• I take it as a sign that "instance" is a bad term that we variously use that term and the term "accumulator" for the same thing, depending on the context, whether or not any accumulation is or could even happen.

I simply rename things to Decider[Proving/Verification]Key and variants of this depending on context. A sign that this is a good choice is the fact that we now have the absurd-looking proving_key->proving_key, which will become non-absurb when the inner proving key type is actually deprecated. At that point the DeciderProvingKey class could move into the flavor, time permitting.

I also have a small change to remove the State struct I recently added to Protogalaxy Prover. This is where the work started before I undertook the big renaming job, and it's small and localized enough that it feels unnecessary to split it out.

Note: renaming of files is done in a follow-on #8383

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,765	1,569	716	770 (+4%)	779 (+1%)
proof_construction_time_sha256_30_ms	11,491	3,092	1,390 (+1%)	1,424	1,467
proof_construction_time_sha256_100_ms	44,165	11,840	5,463	5,679 (+5%)	5,695 (-3%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	35.0 (+3%)	34.0	59.0 (+2%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,533	422	206	224 (-1%)	284 (+5%)
proof_construction_time_poseidon_hash_100_ms	5,654	1,521 (+1%)	680	733	745

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,268	92,906	178,204
l1_rollup_execution_gas	843,109	1,576,643	3,361,997
l2_block_processing_time_in_ms	255	443	831 (+2%)
l2_block_building_time_in_ms	11,248	22,059 (+1%)	44,417 (+1%)
l2_block_rollup_simulation_time_in_ms	11,248	22,059 (+1%)	44,417 (+1%)
l2_block_public_tx_process_time_in_ms	9,597	20,392 (+1%)	42,708 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,951 (-1%)	3,847 (-1%)
node_database_size_in_bytes	12,599,376	16,699,472
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	74.0	380	21,391	44,898	N/A
private-kernel-inner	161 (+1%)	679	72,372	45,020	N/A
private-kernel-reset-tiny	298 (+1%)	695	65,097	44,886	N/A
private-kernel-tail	159	132 (-1%)	50,608	52,921	N/A
base-parity	5.55	N/A	160	96.0	N/A
root-parity	35.3 (+1%)	N/A	73,948	96.0	N/A
base-rollup	3,165 (+2%)	N/A	189,207	664	N/A
block-root-rollup	41.0 (-1%)	N/A	58,205	2,448	N/A
public-kernel-setup	80.7 (-1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	94.0	N/A	104,899	71,222	N/A
public-kernel-tail	843 (+1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	292 (-1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	772	586 (-1%)	453,751	1,825	N/A
public-kernel-teardown	80.0 (-1%)	N/A	105,349	71,222	N/A
merge-rollup	20.0 (-1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	83,591

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	346 (+1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.2 (+1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	405 (+1%)
FeeJuice:deploy	1,376	11,731	389 (+1%)
SchnorrAccount:constructor	1,312	11,731	62.2
SchnorrAccount:entrypoint	2,336	11,731	371 (+1%)
FeeJuice:claim	1,344	11,731	35.8
Token:privately_mint_private_note	1,280	11,731	76.0
FPC:fee_entrypoint_public	1,344	11,731	26.0 (+8%)
Token:transfer	1,312	11,731	213
Benchmarking:create_note	1,344	11,731	75.6 (+2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	30.4 (+14%)
Token:unshield	1,376	11,731	498 (-1%)
FPC:fee_entrypoint_private	1,376	11,731	660 (-5%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	45.6 (+1%)	2,431
FeeJuice:set_portal	12.3 (-6%)	2,930
Token:constructor	77.9 (+4%)	15,813
FPC:constructor	50.3 (+2%)	9,720
FeeJuice:check_balance	36.1 (-1%)	2,357
Token:mint_public	47.6 (-3%)	5,011
Token:assert_minter_and_mint	465 (-1%)	3,155
AuthRegistry:set_authorized	36.7 (-21%)	924
FPC:prepare_fee	75.0 (-1%)	4,245
Token:transfer_public	17.1 (-19%)	10,812
FPC:pay_refund	43.8 (+1%)	5,195
Benchmarking:increment_balance	1,206 (+1%)	3,496
Token:_increase_public_balance	38.9 (-2%)	2,408
FPC:pay_refund_with_shielded_rebate	52.0 (+3%)	5,195

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.151 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.21 (+2%)	3.89 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.115 (+3%)	0.110 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.0	17.9 (+1%)	31.3 (+1%)	58.7	113 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.106	0.104 (+1%)	0.102	0.101	0.101 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.2 (-1%)	25.7	44.1 (-1%)	82.4 (+1%)	162 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	107 (-1%)	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.109 (-1%)	0.104	0.107 (-1%)	0.102 (+1%)	0.102 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,838	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[lucasxia01]

looks fine to me

[lucasxia01]

what's the plan here? Is it to move everything from the proving key to the decider proving key?

[codygunton]

Yes, Honk proving key is not useful, @ledwards2225 agrees

[lucasxia01]

I guess I would disagree, but it's fine that we're merging them

[lucasxia01]

I would also disagree about the "absurd-looking proving_key->proving_key". That's just a result of us having sub-provers, like the oink prover being part of the ultra prover/folding prover.