Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Caller of private kernel can submit "transient" read_requests for "pending" commitments #834

Closed
Tracked by #512
dbanks12 opened this issue Jun 13, 2023 · 0 comments · Fixed by #884
Closed
Tracked by #512
Assignees
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Jun 13, 2023

Kernel needs to match transient reads to commitments.

  1. write C++ logic to iterate over new_commitments and check for matches when a transient read is encountered
  2. add TODO with ticket for optimization where kernel does not iterate in-circuit but instead gets a hint from TS/C++-helper that informs it of the i and j such that we can constrain read_requests[i] == new_commitments[j].
  3. write test that read requests work for commitments that don't exist yet in tree

**Note: do not worry about nullifiers as part of this ticket, although this may lead to e2e failures (EDIT: note sure if this is true actually) in which case this ticket can share 1 PR to master with #836

@dbanks12 dbanks12 added this to A3 Jun 13, 2023
@dbanks12 dbanks12 converted this from a draft issue Jun 13, 2023
@dbanks12 dbanks12 added C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). and removed T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). labels Jun 13, 2023
@dbanks12 dbanks12 changed the title [C++] Private kernel can match flagged read_requests to pending new_commitments [C++] Caller of private kernel can submit read_requests for pending commitments Jun 13, 2023
@dbanks12 dbanks12 changed the title [C++] Caller of private kernel can submit read_requests for pending commitments [C++] Caller of private kernel can submit "transient" read_requests for "pending" commitments Jun 13, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Jun 19, 2023
@jeanmon jeanmon moved this from In Progress to In Review in A3 Jun 20, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jun 20, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants