Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Caller of private kernel can flag read_requests to have membership checks skipped (flagged as read of "pending" commitment) #833

Closed
Tracked by #512
dbanks12 opened this issue Jun 13, 2023 · 0 comments · Fixed by #859
Closed
Tracked by #512

[C++] Caller of private kernel can flag read_requests to have membership checks skipped (flagged as read of "pending" commitment) #833

dbanks12 opened this issue Jun 13, 2023 · 0 comments · Fixed by #859
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Jun 13, 2023 •
edited
Loading

  1. write C++ logic to skip membership check for read request if it is flagged as reading a "pending" commitment
  2. write test for this that gives the kernel some reads flagged as "pending"
@dbanks12 dbanks12 added this to A3 Jun 13, 2023
@dbanks12 dbanks12 converted this from a draft issue Jun 13, 2023
@dbanks12 dbanks12 added C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). labels Jun 13, 2023
@dbanks12 dbanks12 changed the title Caller of private kernel can flag read_requests that are meant to read a "pending" commitment Caller of private kernel can flag read_requests to have membership checks skipped (flagged as read of "pending" commitment) Jun 13, 2023
@dbanks12 dbanks12 changed the title Caller of private kernel can flag read_requests to have membership checks skipped (flagged as read of "pending" commitment) [C++] Caller of private kernel can flag read_requests to have membership checks skipped (flagged as read of "pending" commitment) Jun 13, 2023
@dbanks12 dbanks12 removed the T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). label Jun 13, 2023
@dbanks12 dbanks12 mentioned this issue Jun 13, 2023
Closed
@jeanmon jeanmon moved this from Todo to In Progress in A3 Jun 15, 2023
@jeanmon jeanmon mentioned this issue Jun 15, 2023
Merged
6 tasks
@jeanmon jeanmon moved this from In Progress to In Review in A3 Jun 15, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jun 16, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

833 - Skip validation of the membership for optimistic read requests AztecProtocol/aztec-packages
3 participants
@suyash67 @dbanks12 @jeanmon