Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create specific type for each of the public key types #8080

Closed
benesjan opened this issue Aug 20, 2024 · 0 comments · Fixed by #8099
Closed

Create specific type for each of the public key types #8080

benesjan opened this issue Aug 20, 2024 · 0 comments · Fixed by #8099
Assignees

Comments

@benesjan
Copy link
Contributor

benesjan commented Aug 20, 2024

Just fixed a bug in Nico's recent PR and I realized that the issue was annoying to spot because we were missing key types check.

Create a specific type for each of the key type and use it all around the codebase.

E.g.:

struct NpkM {
    inner: Point
}
struct IvpkM {
    inner: Point
}
struct IvpkM {
    inner: Point
}
struct TpkM {
    inner: Point
}
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 20, 2024
@benesjan benesjan self-assigned this Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant