feat(avm): support aliases in bb-pilcom

[fcarreiro]

Supports generating cpp variables for pol x = sth PIL aliases.

• Cuts down 10k+ lines from poseidon2 and others
• Improves check_circuit 62%! (a bit unexpected!)
  • I think what we see here is how much faster poseidon2 gets with this change. We see it in check_circuit and not in sumcheck because poseidon2 is skippable, which is enabled in sumcheck, but not in check circuit (and the test was on the token transfer). I'm pretty sure that if I prepare a 100% poseidon trace we'll see great improvements. No improvements.
• Improves sumcheck (~20%)
• bugfix: Reduces the degree of some relations by 1 (max goes from 7 to 6)

BEFORE (16 cores)

prove/all_ms: 24789
prove/check_circuit_ms: 16416
prove/create_composer_ms: 0
prove/create_prover_ms: 2580
prove/create_verifier_ms: 0
prove/execute_log_derivative_inverse_commitments_round_ms: 824
prove/execute_log_derivative_inverse_round_ms: 583
prove/execute_pcs_rounds_ms: 232
prove/execute_relation_check_rounds_ms: 2181
prove/execute_wire_commitments_round_ms: 240
prove/gen_trace_ms: 1592

AFTER (16 cores)

prove/all_ms: 13272
prove/check_circuit_ms: 6278
prove/create_composer_ms: 0
prove/create_prover_ms: 1937
prove/create_verifier_ms: 0
prove/execute_log_derivative_inverse_commitments_round_ms: 776
prove/execute_log_derivative_inverse_round_ms: 584
prove/execute_pcs_rounds_ms: 202
prove/execute_relation_check_rounds_ms: 1742
prove/execute_wire_commitments_round_ms: 169
prove/gen_trace_ms: 1471

On 1 cpu, the change is not as big but it still shaves 10s from check_circuit.

BEFORE (1 cpu)

prove/all_ms: 86497
prove/check_circuit_ms: 38114
prove/create_composer_ms: 0
prove/create_prover_ms: 2045
prove/create_verifier_ms: 0
prove/execute_log_derivative_inverse_commitments_round_ms: 8561
prove/execute_log_derivative_inverse_round_ms: 7069
prove/execute_pcs_rounds_ms: 1899
prove/execute_relation_check_rounds_ms: 26534
prove/execute_wire_commitments_round_ms: 542
prove/gen_trace_ms: 1593

AFTER (1 cpu)

prove/all_ms: 74197
prove/check_circuit_ms: 27675
prove/create_composer_ms: 0
prove/create_prover_ms: 2093
prove/create_verifier_ms: 0
prove/execute_log_derivative_inverse_commitments_round_ms: 8913
prove/execute_log_derivative_inverse_round_ms: 7263
prove/execute_pcs_rounds_ms: 1900
prove/execute_relation_check_rounds_ms: 24044
prove/execute_wire_commitments_round_ms: 552
prove/gen_trace_ms: 1618

---

TL;DR: Had to do a major refactor of the codegen. Will come back later to clean some of it up.

I didn't want to, but I started pulling the thread and had to end up doing a lot of refactor/cleanup. The new version of the codegen is (imperceptibly) slower (some things are traversed several times), but I think cleaner.

VM Builder

• Separated computation of columns
• Cleaned up lots of args that were passed to handlebars but not used anymore
• Separated computation of shifts

Lookups and permutations

• Separated the NAME of the lookup/perm and the name of the inverse column

Relation builder

• Most important work is here
• Recurse expressions and look for aliases
• Filtering only the used aliases per file was a bit tough: had to take the transitive closure of the alises used in the relations
• Fixed degree of constant polynomial (was 1, but I think should be 0)
• Fixed BB hacks, not needed anymore after chore(bb): define missing univ-fr operators #7859
• Will have to come back to set up a better way to walk expressions: a visitor (I think powdr has something like this)

[fcarreiro]

• feat(avm): support aliases in bb-pilcom #7904 👈
• chore(avm): do not generate subtrace row #7894
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (FeeJuice:set_portal): 14.3 (+35%)
• avm_simulation_time_ms (Token:transfer_public): 48.6 (+46%)
• app_circuit_proving_time_in_ms (FPC:prepare_fee (avm)): 2,482 (-24%)
• app_circuit_proving_time_in_ms (Token:transfer_public (avm)): 10,341 (-43%)
• app_circuit_proving_time_in_ms (AuthRegistry:consume (avm)): 4,980 (-35%)
• app_circuit_proving_time_in_ms (FPC:pay_refund (avm)): 4,878 (-35%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,790 (+1%)	1,555 (+1%)	706	755 (-1%)	770
proof_construction_time_sha256_30_ms	11,878 (+2%)	3,187 (+1%)	1,414 (+1%)	1,440	1,469
proof_construction_time_sha256_100_ms	44,321 (+1%)	12,394 (+1%)	5,658	5,580	5,498
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0 (-3%)	57.0 (-3%)	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,536 (+1%)	420 (+1%)	199	220 (-5%)	263 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,691 (+1%)	1,537 (+1%)	680 (+1%)	730	744 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,672	92,396	177,716
l1_rollup_execution_gas	1,292,191	2,039,883	3,867,242
l2_block_processing_time_in_ms	250	451 (+2%)	819 (+2%)
l2_block_building_time_in_ms	9,611	18,690	37,381
l2_block_rollup_simulation_time_in_ms	9,610	18,690	37,380
l2_block_public_tx_process_time_in_ms	7,974	16,860	35,398

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,982 (-3%)	3,921
node_database_size_in_bytes	12,693,584	16,908,368
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	95.6 (-2%)	390 (-1%)	21,846	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	174 (-1%)	693	72,545	45,005	N/A	N/A	N/A	N/A
private-kernel-tail	662	749 (+1%)	52,710	52,256	N/A	N/A	N/A	N/A
base-parity	6.01 (-1%)	598 (+3%)	160	96.0	1,712 (-3%)	13,188	19.0	65,536
root-parity	108 (-2%)	128 (-2%)	69,084	96.0	31,656 (+3%)	13,188	19.0	4,194,304
base-rollup	2,975	5,484 (-4%)	187,824	664	96,493 (-2%)	14,020	45.0	16,777,216
root-rollup	95.9 (-1%)	135 (+18%)	54,525	716	28,359 (-1%)	13,988	44.0	4,194,304
public-kernel-setup	89.1 (-1%)	2,831	104,025	71,222	17,708 (+2%)	129,220	3,645	2,097,152
public-kernel-app-logic	105 (-1%)	4,120	104,025	71,222	9,992	129,220	3,645	1,048,576
public-kernel-tail	568	30,173 (+6%)	409,190	16,414	108,596 (+4%)	34,308	679	16,777,216
private-kernel-reset-tiny	194	832	68,621	44,750	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	2,285 (+1%)	1,513	931,564	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	84.7 (-2%)	4,121 (-1%)	104,025	71,222	18,552 (-4%)	129,220	3,645	2,097,152
merge-rollup	59.5 (-1%)	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	68,626 (-6%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	339 (-1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-3%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	472 (-1%)	N/A	N/A
FeeJuice:deploy	1,376	11,731	383 (-1%)	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	176 (-2%)	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	533	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	217 (+2%)	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	23.4 (+2%)	N/A	N/A
Token:transfer	1,312	11,731	430 (-1%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	146,400 (-1%)	2,137 (-15%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	146,464 (-1%)	⚠️ 2,482 (-24%)
Token:transfer_public (avm)	61,614	N/A	N/A	146,464 (-1%)	⚠️ 10,341 (-43%)
AuthRegistry:consume (avm)	41,719	N/A	N/A	146,432 (-1%)	⚠️ 4,980 (-35%)
FPC:pay_refund (avm)	26,227	N/A	N/A	146,432 (-1%)	⚠️ 4,878 (-35%)
Benchmarking:create_note	1,344	11,731	170	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	27.2 (-5%)	N/A	N/A
Token:unshield	1,376	11,731	652 (-5%)	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	851 (-10%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	92.6 (-2%)	8,139
FeeJuice:set_portal	⚠️ 14.3 (+35%)	2,362
Token:constructor	122 (-8%)	31,107
FPC:constructor	93.9 (-10%)	22,380
FeeJuice:mint_public	78.4	6,150
Token:mint_public	97.7 (+6%)	11,720
Token:assert_minter_and_mint	79.7 (-1%)	8,028
AuthRegistry:set_authorized	10.4 (+17%)	4,537
FPC:prepare_fee	276 (-1%)	8,812
Token:transfer_public	⚠️ 48.6 (+46%)	47,374
FPC:pay_refund	63.0 (+5%)	12,114
Benchmarking:increment_balance	1,015	7,450
Token:_increase_public_balance	10.3 (-8%)	8,960
FPC:pay_refund_with_shielded_rebate	137 (-1%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.162 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.18 (+2%)	3.91	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (+2%)	0.111 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.4 (-1%)	17.7 (-1%)	30.6 (-1%)	60.5	115 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.110 (-1%)	0.103 (-1%)	0.0999 (-1%)	0.104 (+1%)	0.103 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.5 (+1%)	25.8 (+1%)	43.2 (-2%)	84.4 (+3%)	169 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108	0.104 (+1%)	0.100 (-6%)	0.105 (+3%)	0.107 (+5%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5 (+2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,756	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[IlyasRidhuan]

Huge improvement for poseidon2 and all the other gadgets! This is my new favourite PR

[fcarreiro]

Merge activity

• Aug 12, 5:29 AM EDT: @fcarreiro started a stack merge that includes this pull request via Graphite.
• Aug 12, 5:31 AM EDT: @fcarreiro merged this pull request with Graphite.

[Maddiaa0]

very nice pilcom refactor