fix(bb.js): Account for extra gates in the c bind circuit size estimate

[vezenovm]

Please read contributing guidelines and remove this line.

We account for extra gates in compute_valid_prover for the normal cpp binary, but we do not account for them in the c binds which are used by bb.js

e.g. this command will fail on master:

BIN=../ts/dest/node/main.js FLOW=prove_then_verify_ultra_honk ./run_acir_tests.sh assert_statement

This now passes on this PR.

[vezenovm]

I added a prove_then_verify flow. I do lean towards we should only use this flow for testing in general, but that is out of scope here.

[ledwards2225]

you mean we should exclusively use prove_then_verify and ditch the AND variant altogether?

[vezenovm]

Yeah, unless we think there is a case where someone will be proving and verifying with the same bb instance at once.

[ledwards2225]

Yeah I think its only real value is for testing because it takes the vk serialization out of the equation. But for the sake of testing the real system I agree we should make sure we thorough tests of the THEN flow

[ledwards2225]

Looks good, thanks for catching this.

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_100_ms (16): 6,885 (+22%)
• proof_construction_time_sha256_30_ms (16): 1,782 (+27%)
• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 3,325 (+43%)
• avm_simulation_time_ms (AuthRegistry:set_authorized): 11.6 (+84%)
• avm_simulation_time_ms (Token:transfer_public): 41.2 (+94%)
• avm_simulation_time_ms (Token:_increase_public_balance): 9.28 (-92%)
• avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 139 (+94%)
• protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 30,897 (+16%)
• protocol_circuit_proving_time_in_ms (base-parity): 1,664 (+56%)
• protocol_circuit_proving_time_in_ms (public-kernel-setup): 18,304 (+20%)
• protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 10,323 (+19%)
• protocol_circuit_proving_time_in_ms (public-kernel-teardown): 19,130 (+18%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,721 (+3%)	1,544 (+1%)	706 (+1%)	739 (-1%)	765 (+1%)
proof_construction_time_sha256_30_ms	11,931 (+5%)	3,199 (+3%)	⚠️ 1,782 (+27%)	1,646 (+13%)	1,518 (+4%)
proof_construction_time_sha256_100_ms	44,004 (+3%)	12,609 (+3%)	⚠️ 6,885 (+22%)	6,177 (+11%)	5,837 (+7%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0 (-3%)	58.0	89.0
proof_construction_time_poseidon_hash_30_ms	1,517 (+3%)	416	199	223 (-3%)	266
proof_construction_time_poseidon_hash_100_ms	5,617 (+3%)	1,519 (+2%)	676	731 (+3%)	743

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,716	6,706	6,704
l1_rollup_execution_gas	611,983	612,124	612,273
l2_block_processing_time_in_ms	244 (-6%)	439	800
l2_block_building_time_in_ms	9,446 (-3%)	18,523	36,903 (-2%)
l2_block_rollup_simulation_time_in_ms	9,445 (-3%)	18,523	36,903 (-2%)
l2_block_public_tx_process_time_in_ms	7,870 (-2%)	16,719	35,036 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,618 (-4%)	3,581
node_database_size_in_bytes	12,689,488	16,941,136
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	96.1 (+1%)	392 (-4%)	21,846	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	172 (-1%)	677 (-7%)	72,545	45,005	N/A	N/A	N/A	N/A
private-kernel-tail	673 (-1%)	789 (-6%)	53,216	50,574	N/A	N/A	N/A	N/A
base-parity	5.82 (-3%)	578 (-1%)	160	96.0	⚠️ 1,664 (+56%)	13,188	19.0	65,536
root-parity	109	125 (+9%)	69,084	96.0	31,156 (+11%)	13,188	19.0	4,194,304
base-rollup	2,961 (-1%)	5,084 (-9%)	182,736	664	98,837 (+14%)	14,020	45.0	16,777,216
root-rollup	96.2 (-1%)	114 (+15%)	54,525	716	27,997 (+10%)	13,988	44.0	4,194,304
public-kernel-setup	93.4 (+2%)	2,795 (+2%)	103,513	70,710	⚠️ 18,304 (+20%)	128,708	3,629	2,097,152
public-kernel-app-logic	104 (-1%)	4,133	103,513	70,710	⚠️ 10,323 (+19%)	128,708	3,629	1,048,576
public-kernel-tail	571 (-2%)	⚠️ 30,897 (+16%)	403,238	11,326	103,847 (+12%)	27,204	457	16,777,216
private-kernel-reset-tiny	182 (-5%)	815 (-7%)	68,621	44,750	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 3,325 (+43%)	1,498 (-7%)	942,862	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	86.0 (-1%)	4,102 (-1%)	103,513	70,710	⚠️ 19,130 (+18%)	128,708	3,629	2,097,152
merge-rollup	59.4 (-1%)	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	70,380 (+6%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	336 (-1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	469 (-1%)	N/A	N/A
GasToken:deploy	1,376	11,731	382 (-2%)	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	175 (-1%)	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	536 (-1%)	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	214 (-3%)	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	30.5 (-4%)	N/A	N/A
Token:transfer	1,312	11,731	486 (-1%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	147,456	2,451 (-8%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	147,520	3,167 (-3%)
Token:transfer_public (avm)	61,614	N/A	N/A	147,520	18,003 (+5%)
AuthRegistry:consume (avm)	41,719	N/A	N/A	147,488	7,458 (-4%)
FPC:pay_refund (avm)	26,227	N/A	N/A	147,488	7,372 (+2%)
Benchmarking:create_note	1,344	11,731	168 (+1%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	27.5 (+1%)	N/A	N/A
Token:unshield	1,376	11,731	739	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	968 (-1%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	93.2 (-1%)	8,139
GasToken:set_portal	9.66 (-21%)	2,362
Token:constructor	122 (+3%)	31,107
FPC:constructor	94.8	24,011
GasToken:mint_public	80.9 (+3%)	6,150
Token:mint_public	82.1 (-3%)	11,720
Token:assert_minter_and_mint	91.0 (+3%)	8,028
AuthRegistry:set_authorized	⚠️ 11.6 (+84%)	4,537
FPC:prepare_fee	293 (+4%)	8,812
Token:transfer_public	⚠️ 41.2 (+94%)	47,374
FPC:pay_refund	61.8 (-6%)	12,114
Benchmarking:increment_balance	1,003 (-1%)	7,450
Token:_increase_public_balance	⚠️ 9.28 (-92%)	8,960
FPC:pay_refund_with_shielded_rebate	⚠️ 139 (+94%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.153 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.13 (-1%)	3.80	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.111 (-2%)	0.107	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	10.9 (-1%)	17.8 (+1%)	29.9 (-3%)	58.7 (+1%)	112
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.105 (-1%)	0.104 (+1%)	0.0986 (-1%)	0.101 (+1%)	0.0994 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.0 (-1%)	25.5 (-3%)	42.9 (-2%)	83.2 (+3%)	161
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.105 (-2%)	0.103 (-3%)	0.101 (-4%)	0.103 (+3%)	0.102
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	63,593	665,010

Transaction size based on fee payment method

| Metric | |
| - | |