fix: checking funded amount is enough

[benesjan]

Fixes #7322

+\ Contains a TXE bug fix. The bug resulted in a test passing even when an error was thrown.

[benesjan]

• feat: protecting fee payer against griefing #7689
• fix: checking funded amount is enough #7648 👈
• fix: key-rotation related issues in TokenWithRefunds #7631
• refactor: TokenWithRefunds optimizations #7628
• chore: renaming private token as token with refunds #7626
• feat: note hashes as points #7618
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[nventuro]

Can't we do funded_amout >= tx_fee? The negated lt makes my brain hurt 😅

[benesjan]

Boolean language also makes my brain hurt but doing it as you proposed would require casting to some uint (you can't do >= on fields) which I didn't do because it would add additional constraint on how large the amounts can be (field is ~254 bits but u64 is just 64).

[nventuro]

y u no test

[benesjan]

conveniently forgot, will add

[nventuro]

I imagine that x + G_amt * y is equal to x if y == 0? So removing this term is the same as saying amount = 0

[benesjan]

I don't follow what you are trying to say here but I've noticed that the related comments needed to be updated as well and I did that in c0570e6

[nventuro]

I meant that the comment now doesn't list amount as being included in the computation, I was thinking how this is equivalent to amount actually being there, but being equal to 0.

This is relevant for things like #7585, since we'd want to avoid having to track whether the amount is inside the point or not.

[benesjan]

There was a bug in TXE which resulted in a test passing even when an error was thrown. Grego fixed it in this PR and what follows are changes made by him.

[benesjan]

There was a bug in TXE which resulted in a test passing even when an error was thrown. Grego fixed it in this PR and what follows are changes made by him.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 59.2 (-39%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 108 (+117%)
• avm_simulation_time_ms (Token:transfer_public): 23.9 (-49%)
• avm_simulation_time_ms (Token:_increase_public_balance): 12.6 (-78%)
• protocol_circuit_proving_time_in_ms (base-parity): 1,440 (-30%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,725	1,540 (-1%)	702	738	764 (-1%)
proof_construction_time_sha256_30_ms	11,764	3,139	1,403	1,432 (-1%)	1,457
proof_construction_time_sha256_100_ms	43,878	12,389 (+1%)	5,641 (-2%)	5,588	5,499 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0 (+2%)	89.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,517	417	199	233 (+3%)	264 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,649 (+1%)	1,516	672 (-1%)	730 (-1%)	743 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,600	6,590	6,588
l1_rollup_execution_gas	611,442	611,583	611,732
l2_block_processing_time_in_ms	771 (+1%)	1,437 (+2%)	2,779
l2_block_building_time_in_ms	10,824 (+1%)	20,735	41,372
l2_block_rollup_simulation_time_in_ms	10,824 (+1%)	20,735	41,372
l2_block_public_tx_process_time_in_ms	9,026 (+1%)	18,771 (-1%)	39,333

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,023	10,140 (+3%)
node_database_size_in_bytes	12,705,872	16,887,888
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	97.1	412 (-1%)	21,798	53,090	N/A	N/A	N/A	N/A
private-kernel-inner	176 (+1%)	717	80,891	53,266	N/A	N/A	N/A	N/A
private-kernel-tail	427	878 (+1%)	61,159	57,447	N/A	N/A	N/A	N/A
base-parity	6.49 (+1%)	663 (-4%)	160	96.0	⚠️ 1,440 (-30%)	13,188	19.0	131,072
root-parity	113	129 (+1%)	69,084	96.0	30,927 (-3%)	13,188	19.0	4,194,304
base-rollup	3,356	5,000	182,192	632	45,244 (+3%)	13,988	44.0	4,194,304
root-rollup	158 (+1%)	122 (-1%)	54,461	684	29,069 (+2%)	13,956	43.0	4,194,304
public-kernel-setup	99.4 (+2%)	2,761	112,985	80,246	18,145 (-4%)	141,444	4,027	2,097,152
public-kernel-app-logic	114 (+1%)	4,114	112,985	80,246	11,466 (+1%)	141,444	4,027	1,048,576
public-kernel-tail	633	27,697 (+7%)	410,726	10,814	71,178 (+6%)	26,372	431	8,388,608
private-kernel-reset-tiny	232	897	76,585	52,961	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	5,247 (-2%)	1,702 (+6%)	888,733	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	93.4 (+1%)	4,119 (-1%)	112,985	80,246	20,402 (-2%)	141,444	4,027	2,097,152
merge-rollup	61.0	N/A	35,678	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	164,113 (+2%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	11,699	352 (+2%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	11,699	27.9 (+1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	11,699	616 (+1%)	N/A	N/A
GasToken:deploy	1,344	11,699	451 (+2%)	N/A	N/A
SchnorrAccount:constructor	1,280	11,699	433	N/A	N/A
SchnorrAccount:entrypoint	2,272	11,699	825	N/A	N/A
Token:privately_mint_private_note	1,248	11,699	505	N/A	N/A
FPC:fee_entrypoint_public	1,312	11,699	89.2	N/A	N/A
Token:transfer	1,280	11,699	1,282	N/A	N/A
AuthRegistry:set_authorized (avm)	18,427	N/A	N/A	102,048	2,033 (+1%)
FPC:prepare_fee (avm)	22,894	N/A	N/A	102,112	2,216 (-2%)
Token:transfer_public (avm)	46,817	N/A	N/A	102,112	6,735
AuthRegistry:consume (avm)	26,670	N/A	N/A	102,080	2,535 (-3%)
FPC:pay_refund (avm)	26,163	N/A	N/A	102,080	3,474 (-2%)
Benchmarking:create_note	1,312	11,699	423	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	11,699	46.0 (-2%)	N/A	N/A
Token:unshield	1,344	11,699	1,107 (-2%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	11,699	1,409 (-3%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	97.5 (+2%)	8,139
GasToken:set_portal	12.9 (-2%)	2,362
Token:constructor	127 (+6%)	16,400
FPC:constructor	91.7	9,304
GasToken:mint_public	81.9 (+1%)	6,150
Token:mint_public	⚠️ 59.2 (-39%)	11,720
Token:assert_minter_and_mint	⚠️ 108 (+117%)	8,028
AuthRegistry:set_authorized	44.9 (-4%)	4,537
FPC:prepare_fee	227 (-3%)	8,812
Token:transfer_public	⚠️ 23.9 (-49%)	32,641
FPC:pay_refund	71.4 (-3%)	12,114
Benchmarking:increment_balance	1,041	7,450
Token:_increase_public_balance	⚠️ 12.6 (-78%)	8,960
FPC:pay_refund_with_shielded_rebate	149 (+1%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.158 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.5 (+1%)	16.9	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.607 (+1%)	0.518	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.3 (+1%)	76.6 (+1%)	132 (+1%)	248 (+2%)	474
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.494 (+1%)	0.470 (+1%)	0.455 (+1%)	0.449 (+2%)	0.443
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.0 (+1%)	116 (+5%)	185 (+2%)	358 (+2%)	699 (-3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.506 (+1%)	0.519 (+4%)	0.489 (+2%)	0.483 (+1%)	0.481 (-2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.5 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.522 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,017	666,910

Transaction size based on fee payment method

| Metric | |
| - | |