Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attestation validation to L1 contract #7579

Closed
Tracked by #7614
just-mitch opened this issue Jul 23, 2024 · 0 comments · Fixed by #7597
Closed
Tracked by #7614

Add attestation validation to L1 contract #7579

just-mitch opened this issue Jul 23, 2024 · 0 comments · Fixed by #7597
Assignees

Comments

@just-mitch
Copy link
Collaborator

just-mitch commented Jul 23, 2024

To work towards SPRTN we will need to validate attestations on the blocks processed.

We will accept a block if it have signatures from >2/3 of the epoch committee.

As we for SPRTN will be using a simplified model of Proof-of-Governance to select the validator set.

This will not focus on the exact method of sampling for now, but use a simple method, and then address it later in #7603. For every epoch we will keep the samples set in storage, this is is really expensive! But it is not meant to be the most efficient, it is meant to provide a reference for the logic, not the most effective way to get to the result.

Checking the signatures itself is relatively simple, we will just be using the ol' reliable ECDSA signatures such that we can use ecrecover directly.

Notice, that as there are no tests currently that is expecting multiple potential sequencers etc, we should allow a case of "base race" if there are no validators in the set. Current E2E will then run this setup.

@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 23, 2024
@LHerskind LHerskind changed the title Add validator registry to L1 contracts Add attestation validation to L1 contract Jul 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants