chore(ci): recover from earthly bug with --no-cache, build images from registry #7462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AztecBot
reviewed
Jul 12, 2024
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 0eaa969 | Previous: 403f4c0 | Ratio |
|---|---|---|---|
nativeClientIVCBench/Full/6 |
13516.417912999997 ms/iter |
12420.894322999999 ms/iter |
1.09 |
wasmClientIVCBench/Full/6 |
42429.245116 ms/iter |
39886.975661000004 ms/iter |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @ludamad @codygunton
This reverts commit 355eae8.
ludamad
changed the title
ludamad
commented
Jul 12, 2024
| @@ -22,58 +22,112 @@ env: | |||
| # kludge until we move away from runners | |||
| WAIT_FOR_RUNNERS: false | |||
| jobs: | |||
| setup: | |||
There was a problem hiding this comment.
refactored to be more like ci.yml
ludamad
commented
Jul 12, 2024
| tester_ttl: 40 | ||
| run: | | ||
| set -eux | ||
| cd ./yarn-project/end-to-end/ | ||
| export FORCE_COLOR=1 | ||
| export EARTHLY_BUILD_ARGS="${{ env.EARTHLY_BUILD_ARGS }}" | ||
| ../../scripts/earthly-ci -P \ | ||
| --secret AWS_ACCESS_KEY_ID=${{ secrets.AWS_ACCESS_KEY_ID }} \ |
There was a problem hiding this comment.
moved the secret passing to earthly-ci
spalladino
added a commit
that referenced
this pull request
Jul 22, 2024
In #7462 the aztec commenter github token was removed from the bench-comment job in favor of loading secrets in the earthly-ci wrapper script. However, the token was never injected into env, so the bench-summary was silently failing due to invalid credentials.
spalladino
added a commit
that referenced
this pull request
Jul 22, 2024
In #7462 the aztec commenter github token was removed from the bench-comment job in favor of loading secrets in the earthly-ci wrapper script. However, the token was never injected into env, so the bench-summary was silently failing due to invalid credentials.
spalladino
added a commit
that referenced
this pull request
Jul 22, 2024
In #7462 the aztec commenter github token was removed from the bench-comment job in favor of loading secrets in the earthly-ci wrapper script. However, the token was never injected into env, so the bench-summary was silently failing due to invalid credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to get a handle on the cache bug by both not reading build images from inline cache, and restarting with
--no-cacheif there's a graph edge bug