feat(avm): make ProverPolynomials::get_row return references #7419

fcarreiro · 2024-07-10T12:23:27Z

This makes the computation of logderivatives ~20x faster, and proving a public token transfer goes from 60s to 14s.

The cost is verbosity.

fcarreiro · 2024-07-10T12:23:42Z

feat(avm): make ProverPolynomials::get_row return references #7419 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

github-actions · 2024-07-10T12:36:20Z

Changes to circuit sizes

Generated at commit: 139db74fd708744551b8e651c51dae68a8259e49, compared to commit: db960772abfead018e4f6da55ae259c6b3d574ef

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail_to_public	+372,376 ❌	+520.89%	+525,285 ❌	+45.54%
private_kernel_reset	+24,132 ❌	+22.30%	+113,621 ❌	+7.19%
private_kernel_reset_big	+11,460 ❌	+14.17%	+51,045 ❌	+4.44%
private_kernel_reset_medium	+5,124 ❌	+7.62%	+19,757 ❌	+2.12%
private_kernel_reset_small	+1,956 ❌	+3.24%	+4,049 ❌	+0.49%
rollup_base	+43 ❌	+0.01%	+140 ❌	+0.00%
public_kernel_tail	+1,492 ❌	+0.15%	-8,703 ✅	-0.20%
public_kernel_teardown	+1 ❌	+0.00%	-10,174 ✅	-0.73%
public_kernel_app_logic	+1 ❌	+0.00%	-10,174 ✅	-0.73%
public_kernel_setup	-112 ✅	-0.06%	-10,258 ✅	-0.77%
private_kernel_tail	-74 ✅	-0.34%	-10,351 ✅	-0.82%
private_kernel_init	-965 ✅	-3.62%	-3,388 ✅	-0.88%
private_kernel_inner	-1,915 ✅	-4.13%	-14,487 ✅	-1.37%
private_kernel_tail_to_public_simulated	0 ➖	0.00%	-64 ✅	-1.92%
public_kernel_app_logic_simulated	0 ➖	0.00%	-64 ✅	-1.92%
public_kernel_setup_simulated	0 ➖	0.00%	-64 ✅	-1.92%
public_kernel_teardown_simulated	0 ➖	0.00%	-64 ✅	-1.92%
private_kernel_init_simulated	0 ➖	0.00%	-64 ✅	-2.78%
private_kernel_inner_simulated	0 ➖	0.00%	-64 ✅	-2.78%
private_kernel_reset_simulated	0 ➖	0.00%	-64 ✅	-2.78%
private_kernel_reset_simulated_big	0 ➖	0.00%	-64 ✅	-2.78%
private_kernel_reset_simulated_medium	0 ➖	0.00%	-64 ✅	-2.78%
private_kernel_reset_simulated_small	0 ➖	0.00%	-64 ✅	-2.78%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail_to_public	443,865 (+372,376)	+520.89%	1,678,810 (+525,285)	+45.54%
private_kernel_reset	132,326 (+24,132)	+22.30%	1,694,245 (+113,621)	+7.19%
private_kernel_reset_big	92,350 (+11,460)	+14.17%	1,199,421 (+51,045)	+4.44%
private_kernel_reset_medium	72,361 (+5,124)	+7.62%	952,008 (+19,757)	+2.12%
private_kernel_reset_small	62,366 (+1,956)	+3.24%	828,341 (+4,049)	+0.49%
rollup_base	339,265 (+43)	+0.01%	3,065,074 (+140)	+0.00%
public_kernel_tail	971,097 (+1,492)	+0.15%	4,408,451 (-8,703)	-0.20%
public_kernel_teardown	241,281 (+1)	+0.00%	1,383,928 (-10,174)	-0.73%
public_kernel_app_logic	241,085 (+1)	+0.00%	1,383,689 (-10,174)	-0.73%
public_kernel_setup	182,749 (-112)	-0.06%	1,320,011 (-10,258)	-0.77%
private_kernel_tail	21,394 (-74)	-0.34%	1,245,982 (-10,351)	-0.82%
private_kernel_init	25,692 (-965)	-3.62%	379,827 (-3,388)	-0.88%
private_kernel_inner	44,471 (-1,915)	-4.13%	1,044,599 (-14,487)	-1.37%
private_kernel_tail_to_public_simulated	1 (0)	0.00%	3,264 (-64)	-1.92%
public_kernel_app_logic_simulated	1 (0)	0.00%	3,264 (-64)	-1.92%
public_kernel_setup_simulated	1 (0)	0.00%	3,264 (-64)	-1.92%
public_kernel_teardown_simulated	1 (0)	0.00%	3,264 (-64)	-1.92%
private_kernel_init_simulated	1 (0)	0.00%	2,241 (-64)	-2.78%
private_kernel_inner_simulated	1 (0)	0.00%	2,241 (-64)	-2.78%
private_kernel_reset_simulated	1 (0)	0.00%	2,241 (-64)	-2.78%
private_kernel_reset_simulated_big	1 (0)	0.00%	2,241 (-64)	-2.78%
private_kernel_reset_simulated_medium	1 (0)	0.00%	2,241 (-64)	-2.78%
private_kernel_reset_simulated_small	1 (0)	0.00%	2,241 (-64)	-2.78%

AztecBot · 2024-07-10T13:19:23Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 426 (+24%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 93.3 (+138%)
avm_simulation_time_ms (Token:_increase_public_balance): 15.1 (-76%)
avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 164 (+46%)
app_circuit_proving_time_in_ms (FPC:prepare_fee (avm)): 1,880 (-40%)
app_circuit_proving_time_in_ms (Token:transfer_public (avm)): 2,173 (-47%)
app_circuit_proving_time_in_ms (AuthRegistry:consume (avm)): 1,786 (-43%)
app_circuit_proving_time_in_ms (FPC:pay_refund (avm)): 8,625 (-69%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 8,814 (+187%)
protocol_circuit_proving_time_in_ms (private-kernel-inner): 26,416 (-49%)
protocol_circuit_proving_time_in_ms (base-rollup): 78,092 (-18%)
protocol_circuit_proving_time_in_ms (public-kernel-setup): 36,655 (-17%)
protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 36,927 (-16%)
protocol_circuit_proving_time_in_ms (public-kernel-teardown): 36,979 (-16%)
protocol_circuit_size_in_gates (private-kernel-inner): 1,048,576 (-50%)
l1_rollup_calldata_gas (4): 9,464 (+44%)
l1_rollup_calldata_gas (8): 9,468 (+44%)
l1_rollup_calldata_gas (16): 9,476 (+44%)
l1_rollup_calldata_size_in_bytes (4): 1,412 (+99%)
l1_rollup_calldata_size_in_bytes (8): 1,412 (+99%)
l1_rollup_calldata_size_in_bytes (16): 1,412 (+99%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,756	1,554	705	769 (+4%)	774 (+1%)
proof_construction_time_sha256_30_ms	11,832	3,167	1,406	1,423 (-1%)	1,464
proof_construction_time_sha256_100_ms	44,121	11,813	5,763 (-1%)	5,441 (+1%)	5,364
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0	87.0
proof_construction_time_poseidon_hash_30_ms	1,534	418	200	226	269 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,664	1,526	682 (+1%)	743 (+2%)	748

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	⚠️ 1,412 (+99%)	⚠️ 1,412 (+99%)	⚠️ 1,412 (+99%)
l1_rollup_calldata_gas	⚠️ 9,464 (+44%)	⚠️ 9,468 (+44%)	⚠️ 9,476 (+44%)
l1_rollup_execution_gas	613,492 (+5%)	613,647 (+5%)	613,806 (+5%)
l2_block_processing_time_in_ms	757	1,414	2,702
l2_block_building_time_in_ms	12,973 (-1%)	25,509	49,704 (-2%)
l2_block_rollup_simulation_time_in_ms	12,972 (-1%)	25,509	49,704 (-2%)
l2_block_public_tx_process_time_in_ms	10,932	23,284	47,459 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,008 (-1%)	9,878 (-1%)
node_database_size_in_bytes	12,423,248	16,199,760
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	107 (-2%)	477 (+14%)	13,749 (-7%)	20,002	55,022	74,208 (-3%)	2,252 (-3%)	524,288
private-kernel-inner	221 (-3%)	741 (-1%)	⚠️ 26,416 (-49%)	82,134	55,022	74,208 (-3%)	2,252 (-3%)	⚠️ 1,048,576 (-50%)
private-kernel-tail	1,065 (+1%)	2,526 (-2%)	49,313 (+1%)	62,409	62,089	14,944	400	2,097,152
base-parity	6.40 (+1%)	941	2,493 (-8%)	160	96.0	2,240	3.00	131,072
root-parity	70.9 (+1%)	60.5 (-17%)	34,465 (-15%)	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,154	5,113	⚠️ 78,092 (-18%)	172,028	632	3,552	44.0	4,194,304
root-rollup	129 (+2%)	77.5 (-17%)	19,753 (-15%)	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	189 (-3%)	2,359 (-4%)	⚠️ 36,655 (-17%)	103,911	80,310	106,944 (-2%)	3,275 (-2%)	2,097,152
public-kernel-app-logic	145 (-2%)	3,294 (-2%)	⚠️ 36,927 (-16%)	103,911	80,310	106,944 (-2%)	3,275 (-2%)	2,097,152
public-kernel-tail	898	23,983 (-14%)	156,755 (-15%)	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	294	1,183 (+2%)	25,876 (-1%)	79,273	55,022	74,208 (-3%)	2,252 (-3%)	1,048,576
public-kernel-teardown	134 (-3%)	3,338 (-2%)	⚠️ 36,979 (-16%)	103,911	80,310	106,944 (-2%)	3,275 (-2%)	2,097,152
merge-rollup	40.4	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	⚠️ 8,814 (+187%)	53,675 (+12%)	N/A	N/A	106,944 (-2%)	3,275 (-2%)	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312	9,344	394	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.2	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	653 (+5%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,344	9,344	565 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	489 (+14%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	829 (+6%)	15,840 (-3%)	4,849 (+1%)	131,072	428 (-4%)
Token:privately_mint_private_note	1,248	9,344	573 (+14%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	107 (+2%)	15,840 (-3%)	1,907 (+4%)	65,536	428 (-4%)
Token:transfer	1,280	9,344	1,662 (+4%)	15,840 (-3%)	10,453 (-12%)	524,288	428 (-4%)
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	91,232	1,261 (-3%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	91,296	⚠️ 1,880 (-40%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	91,296	⚠️ 2,173 (-47%)	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	91,232	⚠️ 1,786 (-43%)	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	91,264	⚠️ 8,625 (-69%)	N/A	N/A
Benchmarking:create_note	1,312	9,344	470 (+10%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	48.5 (+16%)	N/A	N/A	N/A	N/A
Token:unshield	1,344	9,344	1,346 (+2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,741 (+3%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	80.1 (+1%)	13,790
GasToken:set_portal	13.1 (-15%)	3,339
Token:constructor	104 (+1%)	23,692
FPC:constructor	73.5 (+3%)	13,592
GasToken:mint_public	62.2 (+1%)	10,158
Token:mint_public	⚠️ 426 (+24%)	19,034
Token:assert_minter_and_mint	⚠️ 93.3 (+138%)	12,925
AuthRegistry:set_authorized	33.1 (-11%)	7,812
FPC:prepare_fee	101 (-5%)	15,062
Token:transfer_public	34.2 (-11%)	31,218
FPC:pay_refund	128 (-6%)	25,260
Benchmarking:increment_balance	1,316 (-1%)	15,267
Token:_increase_public_balance	⚠️ 15.1 (-76%)	15,006
FPC:pay_refund_with_shielded_rebate	⚠️ 164 (+46%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.156 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4 (+1%)	17.0 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.603 (+1%)	0.523 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.4 (+1%)	75.9	132 (+1%)	245	470
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.495 (+1%)	0.467	0.453 (+1%)	0.444	0.439
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.9 (+1%)	111	183 (+1%)	353	692
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.506 (+1%)	0.499	0.484 (+1%)	0.478	0.476
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.0	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.520	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,082	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

fcarreiro · 2024-07-10T15:02:09Z

Merge activity

Jul 10, 11:02 AM EDT: @fcarreiro merged this pull request with Graphite.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.3</summary> ## [0.46.3](aztec-package-v0.46.2...aztec-package-v0.46.3) (2024-07-11) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.3</summary> ## [0.46.3](barretenberg.js-v0.46.2...barretenberg.js-v0.46.3) (2024-07-11) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.3</summary> ## [0.46.3](aztec-packages-v0.46.2...aztec-packages-v0.46.3) (2024-07-11) ### Features * Add CLI argument for debugging comptime blocks (noir-lang/noir#5192) ([97ecff5](97ecff5)) * Add reset tiny and optimize tail ([#7422](#7422)) ([399917b](399917b)) * **avm:** Calldatacopy and return gadget ([#7415](#7415)) ([ec39e4e](ec39e4e)), closes [#7381](#7381) [#7211](#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](#7419)) ([108fc5f](108fc5f)) * Integrate new proving systems in e2e ([#6971](#6971)) ([723a0c1](723a0c1)) * Lsp rename/find-all-references for struct members (noir-lang/noir#5443) ([97ecff5](97ecff5)) * MSM sorting ([#7351](#7351)) ([5cbdc54](5cbdc54)) * **optimization:** Deduplicate more instructions (noir-lang/noir#5457) ([97ecff5](97ecff5)) * Prefix operator overload trait dispatch (noir-lang/noir#5423) ([97ecff5](97ecff5)) * Remove proof from L1 Rollup process ([#7347](#7347)) ([2645eab](2645eab)), closes [#7346](#7346) * Remove ram tables in note_getter ([#7434](#7434)) ([fd67da3](fd67da3)) * Sync from aztec-packages (noir-lang/noir#5467) ([97ecff5](97ecff5)) * Typing return values of embedded_curve_ops ([#7413](#7413)) ([db96077](db96077)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](#7438)) ([2a7494b](2a7494b)) * Memory init with no other ops gate counting ([#7427](#7427)) ([e7177ba](e7177ba)) * Pass secrets to ci-arm.yml ([#7436](#7436)) ([619501d](619501d)) * Remove compile-time error for invalid indices (noir-lang/noir#5466) ([97ecff5](97ecff5)) * Using different generators in private refund ([#7414](#7414)) ([59b92ca](59b92ca)), closes [#7320](#7320) ### Miscellaneous * **bb:** Fix double increment ([#7428](#7428)) ([7870a58](7870a58)) * **boxes:** Adding an init command for an empty project ([#7398](#7398)) ([a6a605d](a6a605d)) * Bump bb to 0.45.1 (noir-lang/noir#5469) ([97ecff5](97ecff5)) * Disable flaky cheat code test ([7b8c2ba](7b8c2ba)) * Document EmbeddedCurvePoint (noir-lang/noir#5468) ([97ecff5](97ecff5)) * Minimize usage of get_row in inverse computation ([#7431](#7431)) ([f177887](f177887)) * Private refund cleanup ([#7403](#7403)) ([ebec8ff](ebec8ff)) * Replace relative paths to noir-protocol-circuits ([842f6d1](842f6d1)) * Unbundle `check_array_is_initialized` (noir-lang/noir#5451) ([97ecff5](97ecff5)) </details> <details><summary>barretenberg: 0.46.3</summary> ## [0.46.3](barretenberg-v0.46.2...barretenberg-v0.46.3) (2024-07-11) ### Features * **avm:** Calldatacopy and return gadget ([#7415](#7415)) ([ec39e4e](ec39e4e)), closes [#7381](#7381) [#7211](#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](#7419)) ([108fc5f](108fc5f)) * Integrate new proving systems in e2e ([#6971](#6971)) ([723a0c1](723a0c1)) * MSM sorting ([#7351](#7351)) ([5cbdc54](5cbdc54)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](#7438)) ([2a7494b](2a7494b)) * Memory init with no other ops gate counting ([#7427](#7427)) ([e7177ba](e7177ba)) ### Miscellaneous * **bb:** Fix double increment ([#7428](#7428)) ([7870a58](7870a58)) * Minimize usage of get_row in inverse computation ([#7431](#7431)) ([f177887](f177887)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@aztec-package-v0.46.2...aztec-package-v0.46.3) (2024-07-11) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@barretenberg.js-v0.46.2...barretenberg.js-v0.46.3) (2024-07-11) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@aztec-packages-v0.46.2...aztec-packages-v0.46.3) (2024-07-11) ### Features * Add CLI argument for debugging comptime blocks (noir-lang/noir#5192) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Add reset tiny and optimize tail ([#7422](AztecProtocol/aztec-packages#7422)) ([399917b](AztecProtocol/aztec-packages@399917b)) * **avm:** Calldatacopy and return gadget ([#7415](AztecProtocol/aztec-packages#7415)) ([ec39e4e](AztecProtocol/aztec-packages@ec39e4e)), closes [#7381](AztecProtocol/aztec-packages#7381) [#7211](AztecProtocol/aztec-packages#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](AztecProtocol/aztec-packages#7419)) ([108fc5f](AztecProtocol/aztec-packages@108fc5f)) * Integrate new proving systems in e2e ([#6971](AztecProtocol/aztec-packages#6971)) ([723a0c1](AztecProtocol/aztec-packages@723a0c1)) * Lsp rename/find-all-references for struct members (noir-lang/noir#5443) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * MSM sorting ([#7351](AztecProtocol/aztec-packages#7351)) ([5cbdc54](AztecProtocol/aztec-packages@5cbdc54)) * **optimization:** Deduplicate more instructions (noir-lang/noir#5457) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Prefix operator overload trait dispatch (noir-lang/noir#5423) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Remove proof from L1 Rollup process ([#7347](AztecProtocol/aztec-packages#7347)) ([2645eab](AztecProtocol/aztec-packages@2645eab)), closes [#7346](AztecProtocol/aztec-packages#7346) * Remove ram tables in note_getter ([#7434](AztecProtocol/aztec-packages#7434)) ([fd67da3](AztecProtocol/aztec-packages@fd67da3)) * Sync from aztec-packages (noir-lang/noir#5467) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Typing return values of embedded_curve_ops ([#7413](AztecProtocol/aztec-packages#7413)) ([db96077](AztecProtocol/aztec-packages@db96077)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](AztecProtocol/aztec-packages#7438)) ([2a7494b](AztecProtocol/aztec-packages@2a7494b)) * Memory init with no other ops gate counting ([#7427](AztecProtocol/aztec-packages#7427)) ([e7177ba](AztecProtocol/aztec-packages@e7177ba)) * Pass secrets to ci-arm.yml ([#7436](AztecProtocol/aztec-packages#7436)) ([619501d](AztecProtocol/aztec-packages@619501d)) * Remove compile-time error for invalid indices (noir-lang/noir#5466) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Using different generators in private refund ([#7414](AztecProtocol/aztec-packages#7414)) ([59b92ca](AztecProtocol/aztec-packages@59b92ca)), closes [#7320](AztecProtocol/aztec-packages#7320) ### Miscellaneous * **bb:** Fix double increment ([#7428](AztecProtocol/aztec-packages#7428)) ([7870a58](AztecProtocol/aztec-packages@7870a58)) * **boxes:** Adding an init command for an empty project ([#7398](AztecProtocol/aztec-packages#7398)) ([a6a605d](AztecProtocol/aztec-packages@a6a605d)) * Bump bb to 0.45.1 (noir-lang/noir#5469) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Disable flaky cheat code test ([7b8c2ba](AztecProtocol/aztec-packages@7b8c2ba)) * Document EmbeddedCurvePoint (noir-lang/noir#5468) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) * Minimize usage of get_row in inverse computation ([#7431](AztecProtocol/aztec-packages#7431)) ([f177887](AztecProtocol/aztec-packages@f177887)) * Private refund cleanup ([#7403](AztecProtocol/aztec-packages#7403)) ([ebec8ff](AztecProtocol/aztec-packages@ebec8ff)) * Replace relative paths to noir-protocol-circuits ([842f6d1](AztecProtocol/aztec-packages@842f6d1)) * Unbundle `check_array_is_initialized` (noir-lang/noir#5451) ([97ecff5](AztecProtocol/aztec-packages@97ecff5)) </details> <details><summary>barretenberg: 0.46.3</summary> ## [0.46.3](AztecProtocol/aztec-packages@barretenberg-v0.46.2...barretenberg-v0.46.3) (2024-07-11) ### Features * **avm:** Calldatacopy and return gadget ([#7415](AztecProtocol/aztec-packages#7415)) ([ec39e4e](AztecProtocol/aztec-packages@ec39e4e)), closes [#7381](AztecProtocol/aztec-packages#7381) [#7211](AztecProtocol/aztec-packages#7211) * **avm:** Make ProverPolynomials::get_row return references ([#7419](AztecProtocol/aztec-packages#7419)) ([108fc5f](AztecProtocol/aztec-packages@108fc5f)) * Integrate new proving systems in e2e ([#6971](AztecProtocol/aztec-packages#6971)) ([723a0c1](AztecProtocol/aztec-packages@723a0c1)) * MSM sorting ([#7351](AztecProtocol/aztec-packages#7351)) ([5cbdc54](AztecProtocol/aztec-packages@5cbdc54)) ### Bug Fixes * **avm:** Fixes AVM full tests and decrease timeout to 35 minutes ([#7438](AztecProtocol/aztec-packages#7438)) ([2a7494b](AztecProtocol/aztec-packages@2a7494b)) * Memory init with no other ops gate counting ([#7427](AztecProtocol/aztec-packages#7427)) ([e7177ba](AztecProtocol/aztec-packages@e7177ba)) ### Miscellaneous * **bb:** Fix double increment ([#7428](AztecProtocol/aztec-packages#7428)) ([7870a58](AztecProtocol/aztec-packages@7870a58)) * Minimize usage of get_row in inverse computation ([#7431](AztecProtocol/aztec-packages#7431)) ([f177887](AztecProtocol/aztec-packages@f177887)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

feat(avm): make ProverPolynomials::get_row return references

636f08d

fcarreiro requested review from jeanmon, IlyasRidhuan and Maddiaa0 as code owners July 10, 2024 12:23

fcarreiro removed the request for review from IlyasRidhuan July 10, 2024 12:23

fcarreiro requested review from ledwards2225 and ludamad and removed request for jeanmon and Maddiaa0 July 10, 2024 12:23

Maddiaa0 approved these changes Jul 10, 2024

View reviewed changes

a bit less verbose

4f17a49

fcarreiro merged commit 108fc5f into master Jul 10, 2024
91 checks passed

fcarreiro deleted the fc/avm-getrow-references branch July 10, 2024 15:02

AztecBot mentioned this pull request Jul 10, 2024

chore(master): Release 0.46.3 #7423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): make ProverPolynomials::get_row return references #7419

feat(avm): make ProverPolynomials::get_row return references #7419

fcarreiro commented Jul 10, 2024 •

edited

Loading

fcarreiro commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

AztecBot commented Jul 10, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

fcarreiro commented Jul 10, 2024

feat(avm): make ProverPolynomials::get_row return references #7419

feat(avm): make ProverPolynomials::get_row return references #7419

Conversation

fcarreiro commented Jul 10, 2024 • edited Loading

fcarreiro commented Jul 10, 2024 • edited Loading

github-actions bot commented Jul 10, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

AztecBot commented Jul 10, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

fcarreiro commented Jul 10, 2024

Merge activity

fcarreiro commented Jul 10, 2024 •

edited

Loading

fcarreiro commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

AztecBot commented Jul 10, 2024 •

edited

Loading