fix: using different generators in private refund

[benesjan]

Fixes #7320

[benesjan]

• fix: vulnerabilities in private refunds #7424
• fix: using different generators in private refund #7414 👈
• refactor: private refund cleanup #7403
• feat: typing return values of embedded_curve_ops #7413
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 47.8 (-37%)
• app_circuit_proving_time_in_ms (SchnorrAccount:entrypoint): 6,622 (+36%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,697	1,533	701	743	767
proof_construction_time_sha256_30_ms	11,609 (-1%)	3,124 (-1%)	1,406	1,423	1,469 (+1%)
proof_construction_time_sha256_100_ms	43,762	11,703 (-1%)	6,052 (+12%)	5,429 (+1%)	5,336
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0	88.0
proof_construction_time_poseidon_hash_30_ms	1,515	413	198 (-1%)	228 (+3%)	265 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,601	1,506 (-1%)	676	716 (-2%)	741 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,600	6,592	6,600
l1_rollup_execution_gas	583,062	583,205	583,364
l2_block_processing_time_in_ms	757 (-1%)	1,422	2,725 (-1%)
l2_block_building_time_in_ms	13,071	25,583	50,556
l2_block_rollup_simulation_time_in_ms	13,071	25,583	50,556
l2_block_public_tx_process_time_in_ms	10,983	23,358	48,294

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,063 (+1%)	9,940
node_database_size_in_bytes	12,402,768	16,207,952
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	110	426	12,907 (-6%)	20,002	55,022	76,256	2,316	524,288
private-kernel-inner	226	800 (+5%)	46,231 (-2%)	82,134	55,022	76,256	2,316	2,097,152
private-kernel-tail	1,065	2,552 (+1%)	43,945 (-4%)	62,409	62,089	14,944	400	2,097,152
base-parity	6.32 (-1%)	902 (-5%)	2,486 (-1%)	160	96.0	2,240	3.00	131,072
root-parity	70.6	61.0	34,406 (+1%)	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,153	5,118 (+1%)	78,847	172,028	632	3,552	44.0	4,194,304
root-rollup	129 (-2%)	75.4	19,657	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	192	2,345	36,514 (-1%)	103,911	80,310	108,992	3,339	2,097,152
public-kernel-app-logic	148	3,272	37,034	103,911	80,310	108,992	3,339	2,097,152
public-kernel-tail	896 (-1%)	23,410 (-4%)	156,803 (-4%)	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	296 (+1%)	1,150 (+1%)	23,497 (-2%)	79,273	55,022	76,256	2,316	1,048,576
public-kernel-teardown	137	3,300 (+1%)	37,256	103,911	80,310	108,992	3,339	2,097,152
merge-rollup	40.1 (-1%)	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	3,318 (+8%)	44,853	N/A	N/A	108,992	3,339	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312	9,344	394	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	25.4	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	626	N/A	N/A	N/A	N/A
GasToken:deploy	1,344	9,344	568	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	437	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	773 (-1%)	16,352	⚠️ 6,622 (+36%)	131,072	444
Token:privately_mint_private_note	1,248	9,344	528 (-4%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	105 (-5%)	16,352	1,951 (+7%)	65,536	444
Token:transfer	1,280	9,344	1,605 (-5%)	16,352	10,052 (-4%)	524,288	444
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	95,392	1,387 (+15%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	95,456	2,053 (+2%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	95,456	2,413 (+5%)	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	95,424	2,030 (+4%)	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	95,424	9,238 (+2%)	N/A	N/A
Benchmarking:create_note	1,312	9,344	423	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	41.5	N/A	N/A	N/A	N/A
Token:unshield	1,344	9,344	1,309 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,680	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	79.6 (-2%)	13,790
GasToken:set_portal	10.9 (-23%)	3,339
Token:constructor	106 (+3%)	23,692
FPC:constructor	72.0 (+1%)	13,592
GasToken:mint_public	62.1	10,158
Token:mint_public	⚠️ 47.8 (-37%)	19,034
Token:assert_minter_and_mint	93.8	12,925
AuthRegistry:set_authorized	36.1 (+3%)	7,812
FPC:prepare_fee	109 (-2%)	15,062
Token:transfer_public	37.5 (-2%)	31,218
FPC:pay_refund	129 (-2%)	25,260
Benchmarking:increment_balance	1,326	15,267
Token:_increase_public_balance	15.2 (+3%)	15,006
FPC:pay_refund_with_shielded_rebate	165 (+2%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.154 (+3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.601	0.516	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.5	75.7	131	245	469 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.495	0.466	0.452	0.444	0.438 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.8	111 (-1%)	182 (-1%)	352	691 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.505	0.498 (-1%)	0.482 (-1%)	0.477	0.474 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.0	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.519	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,105	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

[just-mitch]

🔥

[just-mitch]

Awesome! I had no idea derive_generators was a thing. This is perfect!!