chore(avm): make stats thread safe

[fcarreiro]

Needed because some things are calculated in parallel.

[fcarreiro]

• chore(avm): make stats thread safe #7393 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[jeanmon]

LGTM

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 73.2 (-79%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 92.0 (+132%)
• avm_simulation_time_ms (Token:transfer_public): 48.4 (+32%)
• avm_simulation_time_ms (Token:_increase_public_balance): 14.8 (-76%)
• avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 163 (+44%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,728 (-1%)	1,547 (-1%)	708 (-1%)	764	769 (-1%)
proof_construction_time_sha256_30_ms	11,734 (-1%)	3,183	1,410 (+1%)	1,447	1,471
proof_construction_time_sha256_100_ms	43,830 (-1%)	11,789 (-2%)	5,583 (+2%)	5,432	5,364
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	59.0	90.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,520	417	201 (-1%)	227 (+2%)	268
proof_construction_time_poseidon_hash_100_ms	5,616 (-1%)	1,525	678	730	748 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,452	9,466	9,452
l1_rollup_execution_gas	613,480	613,645	613,782
l2_block_processing_time_in_ms	757	1,416	2,726 (+1%)
l2_block_building_time_in_ms	12,870 (-1%)	25,429 (-1%)	49,558 (-1%)
l2_block_rollup_simulation_time_in_ms	12,870 (-1%)	25,429 (-1%)	49,558 (-1%)
l2_block_public_tx_process_time_in_ms	10,834 (-1%)	23,208 (-1%)	47,337 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,009	9,961
node_database_size_in_bytes	12,468,304	16,175,184
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	106 (-3%)	398	14,513 (-1%)	20,002	55,022	74,208	2,252	524,288
private-kernel-inner	221	723 (+1%)	28,627	82,134	55,022	74,208	2,252	1,048,576
private-kernel-tail	1,058	2,548 (+3%)	53,112 (-2%)	62,409	62,089	14,944	400	2,097,152
base-parity	6.30	914	2,654 (+1%)	160	96.0	2,240	3.00	131,072
root-parity	69.8	69.7 (+1%)	40,976 (-1%)	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,129 (-1%)	4,896 (-1%)	92,267 (-3%)	172,028	632	3,552	44.0	4,194,304
root-rollup	126 (-1%)	87.3 (+5%)	23,038 (-6%)	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	192 (+2%)	2,398 (-1%)	42,532 (-3%)	103,911	80,310	106,944	3,275	2,097,152
public-kernel-app-logic	144 (-1%)	3,335	43,914 (-2%)	103,911	80,310	106,944	3,275	2,097,152
public-kernel-tail	890	26,775 (-3%)	180,940 (-1%)	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	292	1,144 (-11%)	26,492 (-3%)	79,273	55,022	74,208	2,252	1,048,576
public-kernel-teardown	135 (+2%)	3,342 (-1%)	44,270 (+1%)	103,911	80,310	106,944	3,275	2,097,152
merge-rollup	40.1 (-1%)	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	9,046 (-13%)	58,876	N/A	N/A	106,944	3,275	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312	9,344	394 (-1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	24.7	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	648	N/A	N/A	N/A	N/A
GasToken:deploy	1,344	9,344	556 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	477 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	818 (-1%)	15,840	4,794 (+1%)	131,072	428
Token:privately_mint_private_note	1,248	9,344	543 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	100	15,840	1,758 (+3%)	65,536	428
Token:transfer	1,280	9,344	1,631	15,840	11,682	524,288	428
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	91,232	1,268 (-1%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	91,296	2,693 (-1%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	91,296	3,885 (+2%)	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	91,232	2,997 (+9%)	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	91,264	23,525 (-2%)	N/A	N/A
Benchmarking:create_note	1,312	9,344	466 (-2%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	41.4 (+1%)	N/A	N/A	N/A	N/A
Token:unshield	1,344	9,344	1,340 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,730 (+1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	79.8	13,790
GasToken:set_portal	13.8 (-19%)	3,339
Token:constructor	100 (-4%)	23,692
FPC:constructor	73.4 (-1%)	13,592
GasToken:mint_public	61.0 (-3%)	10,158
Token:mint_public	⚠️ 73.2 (-79%)	19,034
Token:assert_minter_and_mint	⚠️ 92.0 (+132%)	12,925
AuthRegistry:set_authorized	33.3 (-2%)	7,812
FPC:prepare_fee	99.5	15,062
Token:transfer_public	⚠️ 48.4 (+32%)	31,218
FPC:pay_refund	125 (-5%)	25,260
Benchmarking:increment_balance	1,309 (-1%)	15,267
Token:_increase_public_balance	⚠️ 14.8 (-76%)	15,006
FPC:pay_refund_with_shielded_rebate	⚠️ 163 (+44%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.155 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.601	0.513	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.0 (-1%)	75.9 (-1%)	131	245 (-2%)	472 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.490 (-1%)	0.467 (-1%)	0.451	0.444 (-1%)	0.441 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.6	111	183 (+1%)	353 (-1%)	695 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.503	0.500	0.485 (+1%)	0.478	0.477
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.8	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.519	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,082	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

[fcarreiro]

Merge activity

• Jul 9, 9:35 AM EDT: @fcarreiro merged this pull request with Graphite.