Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public inputs correctness in base rollup circuit #7315

Closed
ledwards2225 opened this issue Jul 3, 2024 · 1 comment
Closed

Public inputs correctness in base rollup circuit #7315

ledwards2225 opened this issue Jul 3, 2024 · 1 comment

Comments

@ledwards2225
Copy link
Contributor

The base rollup circuit needs to perform some checks on the public inputs of the tail private kernel. With the Honk integration / introduction of the Tube circuit, the public inputs connection was broken. What needs to happen is roughly the following:

  • a ClientIvc Proof contains a FoldProof which contains the explicit public inputs of the final circuit in the IVC (kernel tail or whatever)
  • These public inputs are extracted in the ProtoGalaxyRecursiveVerifier (part of the ClientIvc recursive verifier, aka the tube) where they become private witnesses by default
  • These witnesses must be explicitly converted to public inputs in that circuit (e.g. builder->set_public_input(pub_input.get_witness_index()) )
  • This will result in those public inputs being explicitly added to the Tube circuit proof which gets sent to the base rollup circuit
  • The base rollup circuit extracts the public inputs from the proof and uses them for Azteky checks as needed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 3, 2024
@ledwards2225
Copy link
Contributor Author

Mistakenly added here. Replaced by bberg issue

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant