Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVM simulator: Increment side effect counter for SENDL2TOL1MSG opcode #7174

Closed
jeanmon opened this issue Jun 25, 2024 · 1 comment
Closed

AVM simulator: Increment side effect counter for SENDL2TOL1MSG opcode #7174

jeanmon opened this issue Jun 25, 2024 · 1 comment

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Jun 25, 2024 •
edited
Loading

avm/journal/trace.ts does not include any tracing for SENDL2TOL1MSG while the VM circuit increments the side effect counter for this opcode (see op_emit_l2_to_l1_msg() in avm_trace.cpp).
@jeanmon jeanmon added this to A3 Jun 25, 2024
@jeanmon jeanmon self-assigned this Jun 25, 2024
@jeanmon jeanmon converted this from a draft issue Jun 25, 2024
@jeanmon jeanmon removed their assignment Jun 25, 2024
@jeanmon
Copy link
Contributor Author

jeanmon commented Jun 26, 2024

This was resolved as part of task #7091 so we can close this one.
.cc @dbanks12

@jeanmon jeanmon closed this as completed Jun 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeanmon