feat: nuking last hardcoded note type ids

[benesjan]

Fixes #5833

[benesjan]

• feat: nuking last hardcoded note type ids #7069 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_30_ms (16): 1,721 (+20%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 91.5 (+32%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_30_ms	11,859 (+1%)	3,205 (+2%)	⚠️ 1,721 (+20%)	1,687 (+3%)	1,485 (-5%)
proof_construction_time_sha256_100_ms	43,886 (+1%)	11,869 (+1%)	5,703 (+5%)	5,568 (+3%)	5,478 (+2%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0 (+2%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,515	415	201	228 (+3%)	266 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,729	1,566 (+1%)	720	785 (+2%)	802 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,468	9,476
l1_rollup_execution_gas	610,285	610,289	610,297
l2_block_processing_time_in_ms	756 (+1%)	1,410 (+1%)	2,721 (+2%)
l2_block_building_time_in_ms	25,566 (-1%)	50,376 (-1%)	99,978
l2_block_rollup_simulation_time_in_ms	25,472 (-1%)	50,081 (-1%)	99,628
l2_block_public_tx_process_time_in_ms	21,889 (-1%)	46,368 (-1%)	95,882

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,001 (+1%)	9,853 (+1%)
node_database_size_in_bytes	12,202,064 (+1%)	16,134,224
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	128 (-2%)	478 (-3%)	13,506 (+5%)	20,634	67,190	92,352	2,819	524,288
private-kernel-inner	390 (-1%)	964 (-3%)	49,532	94,902	67,190	92,352	2,819	2,097,152
private-kernel-tail	369 (-1%)	1,846 (-4%)	50,635 (-6%)	99,121	71,733	14,912	399	2,097,152
base-parity	6.13 (-3%)	1,851 (-3%)	2,838 (+1%)	128	64.0	2,208	2.00	131,072
root-parity	48.4 (-1%)	65.1 (-3%)	43,229 (+10%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,823 (-1%)	4,393	88,411 (+1%)	170,330	756	3,648	47.0	4,194,304
root-rollup	110	83.3	24,635 (+4%)	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	709 (-4%)	3,316	46,604 (+2%)	116,905	93,334	125,344	3,850	2,097,152
public-kernel-app-logic	608 (-1%)	4,216	48,107 (+3%)	116,905	93,334	125,344	3,850	2,097,152
public-kernel-tail	1,396 (-2%)	35,611 (-5%)	190,668 (-1%)	511,910	10,014	14,912	399	8,388,608
private-kernel-reset-small	590 (-1%)	2,048 (+3%)	45,589 (-1%)	123,313	67,190	92,352	2,819	2,097,152
public-kernel-teardown	612 (-2%)	4,201 (+1%)	47,710 (+2%)	116,905	93,334	125,344	3,850	2,097,152
merge-rollup	29.2 (+2%)	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	7,911 (+12%)	99,583 (-4%)	N/A	N/A	125,344	3,850	4,194,304
avm-circuit	N/A	N/A	4,086	N/A	N/A	87,734	0.00	0.00

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	397 (-3%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	39.7 (-1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,762 (-1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	946 (-2%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,410 (-2%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,843	16,768	55,560 (+2%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,655 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	355 (-1%)	16,768	11,105	524,288	457
Token:transfer	1,312	9,944	4,773 (-1%)	16,768	51,357	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,402 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	74.8 (-13%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,999 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,985 (+1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	69.4 (-1%)	13,873
GasToken:set_portal	15.9 (-7%)	3,495
Token:constructor	92.4 (-2%)	24,207
FPC:constructor	61.1 (-1%)	13,893
GasToken:mint_public	52.1 (-1%)	10,241
Token:mint_public	621 (-1%)	19,216
Token:assert_minter_and_mint	⚠️ 91.5 (+32%)	13,034
AuthRegistry:set_authorized	32.2 (-4%)	7,869
FPC:prepare_fee	85.2 (-17%)	15,187
Token:transfer_public	65.5 (+16%)	31,425
FPC:pay_refund	60.3 (-11%)	20,080
Benchmarking:increment_balance	2,654 (-2%)	15,465
Token:_increase_public_balance	56.7 (-3%)	15,089
FPC:pay_refund_with_shielded_rebate	52.8 (-25%)	21,167

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.184 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3 (-1%)	16.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.596 (-1%)	0.515	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.1 (-1%)	75.4 (-1%)	130 (-1%)	244	465
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.491	0.463 (-1%)	0.446 (-1%)	0.441	0.436
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.9 (-1%)	110 (-1%)	180 (-1%)	351	686
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.499 (-1%)	0.496	0.477	0.476	0.471 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.2	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.515	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	85,672	670,983

Transaction size based on fee payment method

| Metric | |
| - | |