refactor: remove prover-pool #6727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexghr
force-pushed
the
05-29-refactor_remove_prover-pool
branch
5 times, most recently
from
e6ee13b to
5e98741
Compare
alexghr
commented
May 29, 2024
Comment on lines
+55
to
+61
| if (newConfig.realProofs !== this.config.realProofs) { | ||
| this.vks = await (newConfig.realProofs | ||
| ? retrieveRealPrivateKernelVerificationKeys(newConfig) | ||
| : getMockVerificationKeys()); | ||
|
|
||
| const circuitProver = await TxProver.buildCircuitProver(newConfig); | ||
| this.agent?.setCircuitProver(circuitProver); |
There was a problem hiding this comment.
Swap in a new circuit prover if we're swtiching to real proofs
alexghr
force-pushed
the
05-29-refactor_remove_prover-pool
branch
2 times, most recently
from
e96c860 to
13ec019
Compare
alexghr
force-pushed
the
05-29-refactor_remove_prover-pool
branch
from
13ec019 to
b46b9f3
Compare
PhilWindle
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
ProverPoolwith adding configurable concurrency level to individual agents. This matches the expection that in production a prover would have multiple independent agents running on separate machines.The
aztec start --provercommand was also changed to start a single agent (which can run multiple proving jobs in parallel)