chore: refactor e2e tests to use the new simulate fn

[nventuro]

With #5762 we can now use simulate() to directly get values out of contract calls (i.e. #2665). This PR refactors some e2e tests that relied on events to get values out and replaces those with proper simulate() calls.

[sklppy88]

Looks great. We may want to open another issue to fix the other e2e tests that use this pattern too, as its a lot better now. Maybe would be too much of an annoyance to do them all at once though.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (32): 481 (-17%)
• note_trial_decrypting_time_in_ms (8): 19.3 (-82%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,844	6,844	6,832
l1_rollup_execution_gas	587,325	587,325	587,313
l2_block_processing_time_in_ms	1,486 (+3%)	5,434 (-1%)	10,462 (+2%)
note_successful_decrypting_time_in_ms	219 (+8%)	⚠️ 481 (-17%)	1,009 (+4%)
note_trial_decrypting_time_in_ms	⚠️ 19.3 (-82%)	89.2 (-3%)	26.4 (-70%)
l2_block_building_time_in_ms	18,265 (+1%)	71,803 (+1%)	143,415 (+1%)
l2_block_rollup_simulation_time_in_ms	18,031 (+1%)	70,931 (+1%)	141,718 (+1%)
l2_block_public_tx_process_time_in_ms	8,343 (+2%)	32,446 (+1%)	65,173 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,767 (+1%)	30,664 (+2%)
note_history_successful_decrypting_time_in_ms	1,265 (+6%)	2,315 (+4%)
note_history_trial_decrypting_time_in_ms	64.6 (+53%)	94.1 (+20%)
node_database_size_in_bytes	19,148,880	35,848,272
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	149 (-1%)	45,173	27,384
private-kernel-inner	165 (+1%)	73,608	27,384
private-kernel-ordering	119	53,138	41,123
base-parity	46.3 (+2%)	128	311
root-parity	7.36 (+3%)	1,244	311
base-rollup	19,153 (+1%)	110,928	957
root-rollup	47.3	4,551	821
public-kernel-app-logic	92.1	50,319	42,853
public-kernel-tail	377	159,352	7,493
merge-rollup	7.57 (+10%)	2,760	957
public-kernel-teardown	87.6 (-1%)	50,319	42,853
public-kernel-setup	86.3	50,319	42,853

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.1 (+1%)	17.9 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.643	0.553 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.7 (+1%)	80.9	265 (+2%)	504	991	1,963	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.530 (+1%)	0.499	0.482 (+2%)	0.470	0.471	0.469	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	61.8 (+2%)	121 (+2%)	380 (+1%)	741	1,471	2,925	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.546 (+2%)	0.542 (+1%)	0.516 (+1%)	0.510	0.510	0.508	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.8 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.591 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	42,886	535,757

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,250 (+2%)	837	3,504 (-1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	801	668	1,283	875 (+1%)	1,968 (+1%)	1,129

[ludamad]

pulling master for revert