Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): push_new_nullifier receives a commitment or zero as 2nd arg - unclear when to use which #5804

Open
Tracked by #220
rahul-kothari opened this issue Apr 17, 2024 · 0 comments
Open
Tracked by #220

feat(docs): push_new_nullifier receives a commitment or zero as 2nd arg - unclear when to use which #5804

rahul-kothari opened this issue Apr 17, 2024 · 0 comments

Comments

@rahul-kothari
Copy link
Contributor

rahul-kothari commented Apr 17, 2024 •
edited
Loading

Add comments in function definition of push_new_nullifier on what the second argument does explaining when to use 0 vs a commitment.

Also add a comment next to any function usage in appropriate noir-contracts that may be used in docs (e,g, easy private voting, token, crowdfunding etc)
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 17, 2024
@rahul-kothari rahul-kothari changed the title feat(Aztec.nr): push_new_nullifier receives a commitment or zero as 2nd arg - unclear when to use which feat(docs): push_new_nullifier receives a commitment or zero as 2nd arg - unclear when to use which Apr 17, 2024
@critesjosh critesjosh mentioned this issue Apr 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rahul-kothari