Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "as any" in merkle tree find operations #5448

Closed
alexghr opened this issue Mar 26, 2024 · 1 comment
Closed

Fix "as any" in merkle tree find operations #5448

alexghr opened this issue Mar 26, 2024 · 1 comment

Comments

@alexghr
Copy link
Contributor

alexghr commented Mar 26, 2024

In #5355 we started adding type parameters for merkle tree leaves but this has caused compiler issues in the MerkleTrees wrapper class (the one that holds all the different state trees). This is probably due to the complex generics used for the trees.

Investigate if it's possible to remove the as any type casts in the files (look for "TODO" comments mentioning this issue).
@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 26, 2024
@alexghr alexghr mentioned this issue Mar 26, 2024
Merged
@alexghr
Copy link
Contributor Author

alexghr commented Jul 22, 2024

Attempted fix in #7443

@alexghr alexghr linked a pull request Jul 22, 2024 that will close this issue
refactor: tree leaf type #7443
Closed
@PhilWindle PhilWindle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 27, 2024
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: tree leaf type AztecProtocol/aztec-packages
2 participants
@alexghr @PhilWindle