-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nullifier non membership #5152
Conversation
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction processing duration by data writes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! :D
assert( | ||
error != NonMembershipCheckErrorCode.NOT_LESS_THAN_NEXT, "Key is not less than the next leaf" | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add an exhaustive check here in case we add more items to the emulated enum and we forgot to add the corresponding assertion here. We could just add at the end an assert(false, "Unknown...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.1</summary> ## [0.27.1](aztec-package-v0.27.0...aztec-package-v0.27.1) (2024-03-12) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.27.1</summary> ## [0.27.1](barretenberg.js-v0.27.0...barretenberg.js-v0.27.1) (2024-03-12) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.27.1</summary> ## [0.27.1](aztec-cli-v0.27.0...aztec-cli-v0.27.1) (2024-03-12) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.27.1</summary> ## [0.27.1](aztec-packages-v0.27.0...aztec-packages-v0.27.1) (2024-03-12) ### Features * Further ClientIVC breakdown ([#5146](#5146)) ([c8e1cb8](c8e1cb8)) * Nullifier non membership ([#5152](#5152)) ([426bd6d](426bd6d)) ### Bug Fixes * Increase the json limit for RPC requests ([#5161](#5161)) ([419958c](419958c)) * Move timers for ClientIVC breakdown ([#5145](#5145)) ([5457edb](5457edb)) ### Miscellaneous * **boxes:** Adding clone contract option ([#4980](#4980)) ([a427aa5](a427aa5)) * Share code between provers ([#4655](#4655)) ([ef10d65](ef10d65)) </details> <details><summary>barretenberg: 0.27.1</summary> ## [0.27.1](barretenberg-v0.27.0...barretenberg-v0.27.1) (2024-03-12) ### Features * Further ClientIVC breakdown ([#5146](#5146)) ([c8e1cb8](c8e1cb8)) ### Bug Fixes * Move timers for ClientIVC breakdown ([#5145](#5145)) ([5457edb](5457edb)) ### Miscellaneous * Share code between provers ([#4655](#4655)) ([ef10d65](ef10d65)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.1</summary> ## [0.27.1](AztecProtocol/aztec-packages@aztec-package-v0.27.0...aztec-package-v0.27.1) (2024-03-12) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.27.1</summary> ## [0.27.1](AztecProtocol/aztec-packages@barretenberg.js-v0.27.0...barretenberg.js-v0.27.1) (2024-03-12) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.27.1</summary> ## [0.27.1](AztecProtocol/aztec-packages@aztec-cli-v0.27.0...aztec-cli-v0.27.1) (2024-03-12) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.27.1</summary> ## [0.27.1](AztecProtocol/aztec-packages@aztec-packages-v0.27.0...aztec-packages-v0.27.1) (2024-03-12) ### Features * Further ClientIVC breakdown ([#5146](AztecProtocol/aztec-packages#5146)) ([c8e1cb8](AztecProtocol/aztec-packages@c8e1cb8)) * Nullifier non membership ([#5152](AztecProtocol/aztec-packages#5152)) ([426bd6d](AztecProtocol/aztec-packages@426bd6d)) ### Bug Fixes * Increase the json limit for RPC requests ([#5161](AztecProtocol/aztec-packages#5161)) ([419958c](AztecProtocol/aztec-packages@419958c)) * Move timers for ClientIVC breakdown ([#5145](AztecProtocol/aztec-packages#5145)) ([5457edb](AztecProtocol/aztec-packages@5457edb)) ### Miscellaneous * **boxes:** Adding clone contract option ([#4980](AztecProtocol/aztec-packages#4980)) ([a427aa5](AztecProtocol/aztec-packages@a427aa5)) * Share code between provers ([#4655](AztecProtocol/aztec-packages#4655)) ([ef10d65](AztecProtocol/aztec-packages@ef10d65)) </details> <details><summary>barretenberg: 0.27.1</summary> ## [0.27.1](AztecProtocol/aztec-packages@barretenberg-v0.27.0...barretenberg-v0.27.1) (2024-03-12) ### Features * Further ClientIVC breakdown ([#5146](AztecProtocol/aztec-packages#5146)) ([c8e1cb8](AztecProtocol/aztec-packages@c8e1cb8)) ### Bug Fixes * Move timers for ClientIVC breakdown ([#5145](AztecProtocol/aztec-packages#5145)) ([5457edb](AztecProtocol/aztec-packages@5457edb)) ### Miscellaneous * Share code between provers ([#4655](AztecProtocol/aztec-packages#4655)) ([ef10d65](AztecProtocol/aztec-packages@ef10d65)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Allow public functions to push non-existent read requests for nullifiers. The kernel will check that the values being read are not in the tree and not in the pending set.
Note that the read requests are only propagated to non-revertible data. We will move all types of requests to
validation_requests
in function circuit's public inputs. And they should always be verified whether the tx reverts or not.