Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure claimer is owner of the note in claim contract #5135

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

sirasistant
Copy link
Collaborator

No description provided.

@sirasistant sirasistant requested a review from benesjan March 11, 2024 16:23
@sirasistant
Copy link
Collaborator Author

I'm going to update the e2e test too

@sirasistant sirasistant marked this pull request as draft March 11, 2024 16:43
@AztecBot
Copy link
Collaborator

AztecBot commented Mar 11, 2024

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (32): 614 (+16%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit edb8c679 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,668 18,820 36,356
l1_rollup_calldata_gas 66,364 238,804 469,964
l1_rollup_execution_gas 647,462 929,162 1,306,144
l2_block_processing_time_in_ms 1,371 (+6%) 4,854 (+5%) 9,560 (+1%)
note_successful_decrypting_time_in_ms 159 (-15%) ⚠️ 614 (+16%) 964 (-2%)
note_trial_decrypting_time_in_ms 60.6 (-33%) 29.9 (-46%) 95.6 (-20%)
l2_block_building_time_in_ms 17,928 (-1%) 67,782 (-1%) 135,014 (-1%)
l2_block_rollup_simulation_time_in_ms 8,058 (-1%) 28,612 56,434
l2_block_public_tx_process_time_in_ms 9,850 (-2%) 39,116 (-1%) 78,483 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,369 (+3%) 27,771 (+1%)
note_history_successful_decrypting_time_in_ms 1,209 (-3%) 2,428 (+1%)
note_history_trial_decrypting_time_in_ms 66.4 (-31%) 164 (+41%)
node_database_size_in_bytes 19,071,056 35,922,000 (+1%)
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 286 (+1%) 44,366 28,244
private-kernel-ordering 215 52,868 14,326
base-parity 1,816 (+1%) 128 311
base-rollup 720 165,787 925
root-parity 1,576 1,244 311
root-rollup 62.8 (-1%) 4,487 789
private-kernel-inner 646 (+1%) 73,771 28,244
public-kernel-app-logic 445 35,260 28,215
public-kernel-tail 172 (-1%) 40,926 28,215
merge-rollup 8.30 (-1%) 2,696 925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.2 (+2%) 15.9 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.592 (+2%) 0.492 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 45.7 (-1%) 72.6 231 (-1%) 444 867 (-2%) 1,725 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.470 (-1%) 0.448 0.420 (-1%) 0.416 0.414 (-1%) 0.413 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.8 106 (-1%) 336 (-1%) 659 1,295 (-2%) 2,632 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.489 0.480 0.457 0.454 0.450 (-1%) 0.454 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.0
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.534

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes
tx_size_in_bytes 22,012

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 3,241 (-1%) 1,746
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 11.1 (+1%) 1,239

@sirasistant sirasistant marked this pull request as ready for review March 12, 2024 08:34
@sirasistant sirasistant changed the title feat: Ensure claimer is owner of the note feat: Ensure claimer is owner of the note in claim contract Mar 19, 2024
Copy link
Contributor

github-actions bot commented Mar 19, 2024

Changes to circuit sizes

Generated at commit: f8561d793056b4f1af184b731d6b604116cd1b12, compared to commit: acffa7b4d41496dea0d16fd94ab98a1a977d14a8

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root -15 ✅ -0.68% -870 ✅ -0.84%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root 2,175 (-15) -0.68% 103,241 (-870) -0.84%

@sirasistant sirasistant merged commit a80519d into master Mar 19, 2024
97 checks passed
@sirasistant sirasistant deleted the arv/fix_claim_contract branch March 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants