Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public-vm: consider passing function selector as part of calldata #5110

Closed
fcarreiro opened this issue Mar 11, 2024 · 1 comment
Closed

public-vm: consider passing function selector as part of calldata #5110

fcarreiro opened this issue Mar 11, 2024 · 1 comment
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@fcarreiro
Copy link
Contributor

In noir-projects/aztec-nr/aztec/src/context/avm.nr, consider passing the function selector as part of calldata, instead of having one extra argument. This might help in reducing the number of registers in the AVM.

cc: @Maddiaa0
@fcarreiro fcarreiro added the C-avm Component: AVM related tickets (aka public VM) label Mar 11, 2024
@fcarreiro fcarreiro added this to A3 Mar 11, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 11, 2024
@fcarreiro fcarreiro mentioned this issue Mar 11, 2024
Merged
@fcarreiro
Copy link
Contributor Author

This was done in #5396, but will likely be turned into it's own opcode once we remove the AvmContextInputs machinery. cc: @dbanks12

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fcarreiro