Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConstantsGen.sol is not formatted upon generation #4447

Closed
just-mitch opened this issue Feb 6, 2024 · 0 comments · Fixed by #4448
Closed

ConstantsGen.sol is not formatted upon generation #4447

just-mitch opened this issue Feb 6, 2024 · 0 comments · Fixed by #4448
Assignees
@just-mitch

Comments

@just-mitch
Copy link
Contributor

ConstantsGen.sol gets generated based on constants.nr. But we don't run forge fmt on it after generation, which causes failures in CI unless you run forge fmt before committing.
@just-mitch just-mitch self-assigned this Feb 6, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 6, 2024
@just-mitch just-mitch linked a pull request Feb 6, 2024 that will close this issue
chore: format l1-contracts after generating constants #4448
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@just-mitch just-mitch

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: format l1-contracts after generating constants AztecProtocol/aztec-packages
1 participant
@just-mitch