Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Notes): Allow getNotes to only return nullified notes. #4217

Open
Tracked by #2783
nventuro opened this issue Jan 25, 2024 · 2 comments
Open
Tracked by #2783

feat(Notes): Allow getNotes to only return nullified notes. #4217

nventuro opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
C-aztec.nr Component: Aztec smart contract framework

Comments

@nventuro
Copy link
Contributor

#4208 introduces a way to query both active and nullified notes, but it is desirable to make it also possible to only retrieve nullified notes.

This requires not just adding a new option to the status field in NoteFilter, but also emitting a nullifier inclusion proof. This will be made easier by #4179.

@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 25, 2024
@nventuro nventuro added the C-aztec.nr Component: Aztec smart contract framework label Jan 26, 2024
@rahul-kothari
Copy link
Contributor

Is this a duplicate of #3755 @nventuro ?

@nventuro
Copy link
Contributor Author

No, not really. #3755 was tackled in #4208 (now #4238), but retriving only nullified notes without retrieving any active notes was left out. This issue is about adding that second part.

@LHerskind LHerskind changed the title Allow getNotes to only return nullified notes. feat(Notes): Allow getNotes to only return nullified notes. Mar 9, 2024
@sklppy88 sklppy88 self-assigned this Apr 5, 2024
@sklppy88 sklppy88 moved this from Todo to In Progress in A3 Apr 7, 2024
@sklppy88 sklppy88 moved this from In Progress to Todo in A3 Apr 11, 2024
@sklppy88 sklppy88 moved this from Todo to On Hold in A3 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-aztec.nr Component: Aztec smart contract framework
Projects
Status: No status
Development

No branches or pull requests

3 participants