Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend E2E to use contract and check state #399

Closed
LHerskind opened this issue Apr 27, 2023 · 0 comments · Fixed by #431
Closed

Extend E2E to use contract and check state #399

LHerskind opened this issue Apr 27, 2023 · 0 comments · Fixed by #431
Assignees

Comments

@LHerskind
Copy link
Contributor

Currently as no proofs are verified, changes to the l2block layout that will brick calldata computation in contract can pass as it is never checked.

Extend the current E2E tests such that the it is checked that the public input hash computed in contract matched the expected value alerting people before they break it.

@LHerskind LHerskind added this to A3 Apr 27, 2023
@LHerskind LHerskind converted this from a draft issue Apr 27, 2023
@LHerskind LHerskind self-assigned this Apr 27, 2023
@LHerskind LHerskind moved this from Todo to In Review in A3 Apr 28, 2023
@LHerskind LHerskind linked a pull request May 3, 2023 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 May 4, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant