fix(cli): Unbox command should run as release

[spalladino]

Running aztec-cli unbox with the 0.17.0 CLI will unbox creating an .aztec-packages folder and setting dependencies as portals:

~/Projects/tmp/unbox$ which aztec-cli
/home/santiago/.aztec/bin/aztec-cli
~/Projects/tmp/unbox$ aztec-cli --version
0.17.0
~/Projects/tmp/unbox$ ls blank/.aztec-packages/
barretenberg  yarn-project
~/Projects/tmp/unbox$ jq .dependencies blank/package.json 
{
  "@aztec/accounts": "portal:.aztec-packages/yarn-project/accounts",
  "@aztec/aztec.js": "portal:.aztec-packages/yarn-project/aztec.js",
  "serve": "^14.2.1"
}

This seems to point to aztec-cli not picking up the COMMIT_TAG env var here:

aztec-packages/yarn-project/cli/src/cmds/unbox.ts

Lines 38 to 55 in fc1d539

	const isRelease = !!process.env.COMMIT_TAG;
	if (isRelease) {
	packageJsonUpdatePackageVersions(`${destPath}/package.json`, () => cliVersion);
	nargoTomlUpdateToGithubDeps(`${destPath}/src/contracts/Nargo.toml`, cliVersion);
	} else {
	// Allows testing of unbox against whatever the local code is.
	// First copy in dev dependencies to .aztec-packages.
	copyDependenciesToBox(dirName, destPath);
	// Update config to point to dev dependencies.
	packageJsonInjectLocalResolutions(`${destPath}/package.json`);
	packageJsonUpdatePackageVersions(`${destPath}/package.json`, dep => resolutions[dep]);
	nargoTomlUpdateToDevPath(`${destPath}/src/contracts/Nargo.toml`);
	// Set box to use yarn berry, and node-modules linkage.
	process.chdir(destPath);
	execSync(`yarn set version berry`, { stdio: 'inherit' });
	appendFileSync(`.yarnrc.yml`, 'nodeLinker: node-modules');
	}
	}

This fix should make the env var available to the CLI. However, I haven't tested this (is it possible to build the cli image as if it were a release?), and it's unclear if this is the "right" fix. Should the CLI expect that env var at all? Should the default be "release mode" and only require an env var to run in "dev mode"?

[alexghr]

WDYT if we set the COMMIT_TAG env var here so that every project has access to it?

aztec-packages/yarn-project/Dockerfile.prod

Line 33 in fc1d539

ENV NODE_VERSION=18.19.0

The reason ARG COMMIT_TAG was added to the CLI's dockerfile was so its image would be rebuild on releases tags.

[spalladino]

I like the idea! @spypsy what do you think?

[spypsy]

Yep, can't think of a reason not to have it there.

[spalladino]

Updated, please re-review!

[spypsy]

Haven't actually tried it before but I assume the ENV var gets passed down to images that use this one

[spalladino]

Just tested it, and it does:

~/Projects/tmp/docker$ cat Dockerfile.base 
FROM alpine

ENV BASE_FOO=foo
ENV BASE_BAR=bar

~/Projects/tmp/docker$ cat Dockerfile.child 
FROM env-test-base

ENV BASE_BAR=overridden
~/Projects/tmp/docker$ docker run --rm env-test-child env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=e4a1237e0b26
BASE_FOO=foo
BASE_BAR=overridden
HOME=/root