Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AztecU128 with the U128 struct in Noir's stdlib #3946

Closed
kevaundray opened this issue Jan 11, 2024 · 0 comments · Fixed by #3951
Closed

Replace AztecU128 with the U128 struct in Noir's stdlib #3946

kevaundray opened this issue Jan 11, 2024 · 0 comments · Fixed by #3951

Comments

@kevaundray
Copy link
Contributor

## Problem

These two structs serve roughly the same purpose. The Aztec version was made just for type safety reasons, so it doesn't apply the necessary constraints.

## Solution

Replace usage of Aztec's version of U128 with Noir's. This will likely reduce performance by some delta given that Noirs version uses two u64s and Aztec's version uses a Field.

We can make the transition smoother by adding from_field to Noir's version of U128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant