Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rollup circuits to incorporate public data in calldata hashing #390

Closed
spalladino opened this issue Apr 27, 2023 · 0 comments · Fixed by #431
Closed

Update rollup circuits to incorporate public data in calldata hashing #390

spalladino opened this issue Apr 27, 2023 · 0 comments · Fixed by #431
Assignees
@LHerskind
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Milestone
🦜 Mimic Public Fu...

Comments

@spalladino
Copy link
Collaborator

Equivalent to #272, but in the calldata_hash of the rollup contracts. See here:

https://github.com/AztecProtocol/aztec3-packages/blob/21ffc83a81af06cb91b489d50e5198a36446a2f8/circuits/cpp/src/aztec3/circuits/rollup/base/native_base_rollup_circuit.cpp#L142
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 27, 2023
@spalladino spalladino added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Apr 27, 2023
@LHerskind LHerskind self-assigned this May 2, 2023
@LHerskind LHerskind mentioned this issue May 2, 2023
Merged
6 tasks
@PhilWindle PhilWindle moved this from Todo to Done in A3 May 4, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
None yet
Milestone
🦜 Mimic Public Function Call
Development

Successfully merging a pull request may close this issue.

Add E2E calldataHash test (sol/ts/cpp) AztecProtocol/aztec-packages
2 participants
@spalladino @LHerskind