chore: Cleanup sandbox dependent tests #3861

PhilWindle · 2024-01-05T17:21:07Z

This PR removed the assumption of most tests running against the sandbox.

Only docs tests imply sandbox usage.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

AztecBot · 2024-01-05T18:01:39Z

Benchmark results

Metrics with a significant change:

note_successful_decrypting_time_in_ms (8): 362 (-25%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a2b267bf and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	223,008	868,316	3,449,588
l1_rollup_execution_gas	867,117	3,746,369	23,306,353
l2_block_processing_time_in_ms	1,333 (-2%)	5,101	21,007
note_successful_decrypting_time_in_ms	⚠️ 362 (-25%)	1,111 (+1%)	4,105
note_trial_decrypting_time_in_ms	71.4 (-20%)	38.5 (-2%)	135 (-6%)
l2_block_building_time_in_ms	14,904	59,328	238,380
l2_block_rollup_simulation_time_in_ms	10,587	42,205	170,005
l2_block_public_tx_process_time_in_ms	4,288	17,048 (-1%)	68,112

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,968 (-1%)	29,013
note_history_successful_decrypting_time_in_ms	2,836 (+6%)	5,275 (-5%)
note_history_trial_decrypting_time_in_ms	96.1 (-13%)	170 (+15%)
node_database_size_in_bytes	3,613,591	3,723,565
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	211	44,709	25,561
private-kernel-ordering	137	30,953	14,809
base-rollup	1,075	128,374	881
root-rollup	84.3	4,088	889
private-kernel-inner	287	71,236	25,561
public-kernel-private-input	202	31,891	25,561
public-kernel-non-first-iteration	200	31,933	25,561
merge-rollup	9.71	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_ms	11.1	86.6 (-2%)	15.7 (+12%)	17.9 (-1%)	24.9 (+7%)	49.8	88.2	243 (-1%)	468	911 (+1%)	3,559
batch_insert_into_indexed_tree_ms	N/A	N/A	N/A	64.0 (-1%)	N/A	59.5	110 (-1%)	360 (-1%)	732	1,404	5,562

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,487	31,877

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	344	969

Metric	1 public data writes
tx_sequencer_processing_time_ms	529

spalladino · 2024-01-05T21:49:47Z

yarn-project/aztec.js/src/sandbox/index.ts

-/**
- * Function to wait until the sandbox becomes ready for use.
- * @param pxe - The pxe client connected to the sandbox.
- */
-export async function waitForSandbox(pxe?: PXE) {
-  pxe = pxe ?? createPXEClient(PXE_URL);
-  while (true) {
-    try {
-      await pxe.getNodeInfo();
-      break;
-    } catch (err) {
-      await sleep(1000);
-    }
-  }
-}


How about keeping this function but renaming it to waitForPXE..?

Heh, just saw we have it but as part of the e2e utils. I think it makes sense to promote it to an util here.

spalladino · 2024-01-05T21:52:45Z

yarn-project/end-to-end/src/e2e_aztec_js_browser.test.ts

+  const { pxe: pxeService } = await setup(1);
+  let pxeURL = PXE_URL;
+  if (!PXE_URL) {
+    const pxeRPCServer = createPXERpcServer(pxeService);
+    pxeRPCServer.start(PXE_PORT);
+    pxeURL = `http://localhost:${PXE_PORT}`;
+  }


I understand that PXE_URL here is the URL to a running instance of the pxe. So, if it's set, we shouldn't need to run setup, right?

setup also ensures you have the required number of accounts deployed (in this case, 1).

Ah you're right, I missed the if PXE_URL check within setup

spalladino · 2024-01-05T21:57:34Z

yarn-project/end-to-end/src/e2e_card_game.test.ts

+const ENCRYPTION_KEYS = [
+  GrumpkinScalar.fromString('2153536ff6628eee01cf4024889ff977a18d9fa61d0e414422f7681cf085c281'),
+  GrumpkinScalar.fromString('aebd1b4be76efa44f5ee655c20bf9ea60f7ae44b9a7fd1fd9f189c7a0b0cdae'),
+  GrumpkinScalar.fromString('0f6addf0da06c33293df974a565b03d1ab096090d907d98055a8b7f4954e120c'),
+];


In the accounts PR I'm not exporting these from @aztec/accounts/testing. Maybe it makes sense to load that import, so we avoid duplicating these constants? I know the test would pass anyway, since they'd be automatically created, but it'd be slower.

spalladino · 2024-01-05T21:58:11Z

yarn-project/end-to-end/src/e2e_card_game.test.ts

+    for (let i = 0; i < toRegister.length; i++) {
+      logger(`Deploying account contract ${i}/${toRegister.length}...`);
+      const encryptionPrivateKey = toRegister[i];
+      const account = getSchnorrAccount(pxe, encryptionPrivateKey, GrumpkinScalar.random());
+      const wallet = await account.waitDeploy({ interval: 0.1 });
+      wallets.push(wallet);


I know it's not part of this PR, but should we do this in a beforeAll instead of a beforeEach to speed things up?

Probably, yes.

spalladino · 2024-01-05T22:00:22Z

yarn-project/end-to-end/src/e2e_cli.test.ts

-const { PXE_URL } = process.env;
-if (PXE_URL) {
-  RPC_URL = PXE_URL;
-}


Why remove this? I think it's useful to be able to run this suite against a running server, so we don't have to recreate it every time. And it's not like it assumes it's a sandbox: it just requires a pxe.

Yes, I realise the issues with the changes I made. Should be sorted now.

spalladino · 2024-01-08T16:58:26Z

yarn-project/end-to-end/src/shared/cli.ts

+      const { pxe: pxeService, rpcURL: pxeURL } = await setup();
+      pxe = pxeService;
+      rpcURL = pxeURL;


Suggested change

const { pxe: pxeService, rpcURL: pxeURL } = await setup();

pxe = pxeService;

rpcURL = pxeURL;

({ pxe, rpcURL } = await setup());

I think this syntax works

spalladino · 2024-01-08T16:59:00Z

yarn-project/end-to-end/src/e2e_aztec_js_browser.test.ts

+  const { pxe: pxeService } = await setup(1);
+  let pxeURL = PXE_URL;
+  if (!PXE_URL) {
+    const pxeRPCServer = createPXERpcServer(pxeService);
+    pxeRPCServer.start(PXE_PORT);
+    pxeURL = `http://localhost:${PXE_PORT}`;
+  }


Ah you're right, I missed the if PXE_URL check within setup

spypsy · 2024-01-09T11:33:47Z

yarn-project/end-to-end/src/shared/browser.ts

-            getSandboxAccountsWallets,
-          } = window.AztecJs;
+          const { Contract, AztecAddress, createPXEClient: createPXEClient, getDeployedTestAccountsWallets } = window.AztecJs;
+          console.log(`RPC URL ${pxeURL}`);


Suggested change

console.log(`RPC URL ${pxeURL}`);

console.log(`RPC URL ${rpcUrl}`);

Removed this line altogether

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.18.0</summary> ## [0.18.0](aztec-packages-v0.17.0...aztec-packages-v0.18.0) (2024-01-16) ### ⚠ BREAKING CHANGES * Remove `Directive::Quotient` ([#4019](#4019)) * define key type in maps ([#3841](#3841)) * implement keccakf1600 in brillig ([#3914](#3914)) * add blake3 opcode to brillig ([#3913](#3913)) * Remove opcode supported from the backend ([#3889](#3889)) ### Features * `PartialStateReference` and `StateReference` structs ([#3827](#3827)) ([3ba0369](3ba0369)) * `StateDiffHints` ([#3919](#3919)) ([8774795](8774795)), closes [#3916](#3916) * Acir cleanup ([#3845](#3845)) ([390b84c](390b84c)) * Add ACIR opcodes for ECADD and ECDOUBLE ([#3878](#3878)) ([537630f](537630f)) * Add blake3 opcode to brillig ([#3913](#3913)) ([34fad0a](34fad0a)) * Add data availability oracle ([#3897](#3897)) ([5441753](5441753)), closes [#3890](#3890) * Add str support for args + add name/symbol/decimal to token ([#3862](#3862)) ([0bf5d8c](0bf5d8c)) * Bench bb in pr's, docker shell utils ([#3561](#3561)) ([5408919](5408919)) * Benchmark protogalaxy prover ([#3958](#3958)) ([5843722](5843722)) * Benchmarks for basic functionality and IPA improvements ([#4004](#4004)) ([fd1f619](fd1f619)) * Body hash as buffer in TS + minor cleanup ([#4012](#4012)) ([e28a6bf](e28a6bf)) * Bootstrap cache v2 ([#3876](#3876)) ([331598d](331598d)) * Counters in private functions ([#3850](#3850)) ([23bbf75](23bbf75)) * Generate json blocks for tests ([#3923](#3923)) ([a09fd2a](a09fd2a)) * Implement keccakf1600 in brillig ([#3914](#3914)) ([a182381](a182381)) * Parallel IPA ([#3882](#3882)) ([7002a33](7002a33)) * Pil lookups w/ xor table example ([#3880](#3880)) ([544d24e](544d24e)) * Poseidon2 stdlib impl ([#3551](#3551)) ([50b4a72](50b4a72)) * Protogalaxy Decider and complete folding tests ([#3657](#3657)) ([cfdaf9c](cfdaf9c)) * Reexport `protocol_types` from `aztec-nr` ([#3926](#3926)) ([9bd22f7](9bd22f7)) * Relations vs widgets benchmarking ([#3931](#3931)) ([3af64ef](3af64ef)) * Remove opcode supported from the backend ([#3889](#3889)) ([1fd135c](1fd135c)) * Reorganize acir composer ([#3957](#3957)) ([e6232e8](e6232e8)) * Replace bitwise ORs in `U256:from_bytes32` with addition ([#3947](#3947)) ([efd7660](efd7660)) * Standalone calldata test ([#3842](#3842)) ([7353a35](7353a35)) * Sync with main noir repo ([#3939](#3939)) ([69c7e99](69c7e99)) * Update noir ([#3979](#3979)) ([271de71](271de71)) * Verify state hash is correct before publishing to L1 ([#3915](#3915)) ([a53c261](a53c261)) ### Bug Fixes * **aztec-nr:** Broken nargo url ([#3925](#3925)) ([034bc30](034bc30)) * Back out the buggy branch condition ([#3988](#3988)) ([9f61ed1](9f61ed1)) * Bb unnecessary env var ([#3901](#3901)) ([f127e5a](f127e5a)) * Broken links by paterson1 ([#3902](#3902)) ([6783aaa](6783aaa)) * **cli:** Unbox command should run as release ([#3974](#3974)) ([80c3805](80c3805)) * **cli:** Unbox should set up the accounts package ([#3972](#3972)) ([065e988](065e988)) * Docusaurus start command ([#3968](#3968)) ([87c0b07](87c0b07)) * Dont spam logs with yarn install ([#4027](#4027)) ([949c5ab](949c5ab)) * Fix compilation of `token` box ([#3981](#3981)) ([0f994d0](0f994d0)) * Mirror_noir_subrepo.yml erroring ([#3954](#3954)) ([2ac1b9c](2ac1b9c)) * Quote the glob string for ignore branches for protocol-circuits-gate-diff ([#3990](#3990)) ([a43889d](a43889d)) * Reprocess notes in pxe when a new contract is added ([#3867](#3867)) ([ccbff99](ccbff99)) * Segment tree insertion stats by depth ([#4029](#4029)) ([2787bae](2787bae)) * Store blockhash alongside blocks ([#3950](#3950)) ([12b07fa](12b07fa)), closes [#3870](#3870) * Swap branch exclusion for release-please on report gates diff workflow ([#3994](#3994)) ([70b2ffd](70b2ffd)) * Typos in authwit.md by czepluch ([#3921](#3921)) ([4b9d0f4](4b9d0f4)) * Yellowpaper docusaurus start command ([#3969](#3969)) ([4977cbc](4977cbc)) ### Miscellaneous * Add a link back to `aztec-packages` in noir sync PR ([#4018](#4018)) ([7d89f3b](7d89f3b)) * Catch up note processors could be synced more efficiently ([#3933](#3933)) ([df54f33](df54f33)) * **ci:** Require boxes CI to succeed ([#3983](#3983)) ([93cbea1](93cbea1)) * Cleanup duplicated methods for structs after traits ([#3912](#3912)) ([60b59da](60b59da)) * Cleanup sandbox dependent tests ([#3861](#3861)) ([158c5be](158c5be)) * Codegen acir opcodes after renaming arithmetic to assertzero ([#3896](#3896)) ([c710ce1](c710ce1)) * Define key type in maps ([#3841](#3841)) ([cf15adb](cf15adb)) * Delete the compiler from `noir-compiler` ([#3959](#3959)) ([9aa0986](9aa0986)) * Deploy canary release of bb.js to npm via CCI ([#3917](#3917)) ([bdeb10c](bdeb10c)) * Do not fail jq dependencies check for package with no deps ([#3894](#3894)) ([22c65bf](22c65bf)) * Do not pass redundant txNullifier when computing notes ([#3943](#3943)) ([9355cda](9355cda)) * Do not run CCI on release-please branches ([#3984](#3984)) ([c38dbd2](c38dbd2)) * **docs:** Fix ts code in token bridge tutorial ([#3888](#3888)) ([f53f8ed](f53f8ed)) * **docs:** Move map keys to new release in migration guide ([#3977](#3977)) ([6356d94](6356d94)) * **docs:** Update missing @aztec/accounts missing import in testing.md ([#3903](#3903)) ([755668a](755668a)) * Document `witness_buf_to_witness_data` ([#3940](#3940)) ([fbaa726](fbaa726)) * End to end test node & pxe persistence ([#3911](#3911)) ([6164ccd](6164ccd)) * Enforce immutable yarn installs in CI ([#3964](#3964)) ([f3104ac](f3104ac)) * Fix rust tests ([#3963](#3963)) ([a907c3b](a907c3b)) * Fix sidebar index links ([#3942](#3942)) ([984f1f8](984f1f8)) * Git subrepo commit (merge) noir ([#3955](#3955)) ([2c2bc69](2c2bc69)) * Introduce EventSelector class ([#3960](#3960)) ([7315f2c](7315f2c)) * Investigate P2P test ([#3929](#3929)) ([0fca2c4](0fca2c4)) * Move types to circuit-types ([#3967](#3967)) ([f81b7c0](f81b7c0)) * Persistence uses TokenContract ([#3930](#3930)) ([1a052c4](1a052c4)) * Pull in noir from upstream ([#3904](#3904)) ([ab07e7e](ab07e7e)) * Recreated types package without circuits.js dependency ([#3970](#3970)) ([fc1d539](fc1d539)) * Refactor serialisation functions and sibling paths ([#3980](#3980)) ([1a936fc](1a936fc)) * Remove 'extern template's, expand macros ([#3953](#3953)) ([5fe9908](5fe9908)) * Remove `Directive::Quotient` ([#4019](#4019)) ([824d76f](824d76f)) * Remove sandbox and cli npm pkgs ([#3567](#3567)) ([a8cf1bf](a8cf1bf)) * Reorganize benchmarks ([#3909](#3909)) ([730766b](730766b)) * Replace `AztecU128` with `U128` ([#3951](#3951)) ([e3b288d](e3b288d)) * Replace relative paths to noir-protocol-circuits ([2c25f04](2c25f04)) * Replace relative paths to noir-protocol-circuits ([0c8b770](0c8b770)) * Replace relative paths to noir-protocol-circuits ([d3819ba](d3819ba)) * Standardise toml parsers ([#3910](#3910)) ([963035f](963035f)) * Sync noir ([#4025](#4025)) ([4e90d7b](4e90d7b)) * Sync Noir repo ([#4020](#4020)) ([876603e](876603e)) * **yellowpaper:** Cleanup avm sidebar, fix filename case ([#3952](#3952)) ([5211060](5211060)) * Yp docs sidebar (with some auto-formatting) ([#3893](#3893)) ([f7b007a](f7b007a)) ### Documentation * Noir git subrepo usage ([#3962](#3962)) ([2e4c9de](2e4c9de)) * Streamlined pr template ([#3932](#3932)) ([5ec1559](5ec1559)) * **yellowpaper:** Avm call pointers, bytecode lookups, circuit io ([#3898](#3898)) ([45e1ed2](45e1ed2)) * **yellowpaper:** Avm circuit architecture ([#3934](#3934)) ([6aed1d0](6aed1d0)) * **yellowpaper:** First draft of avm circuit memory ([#3865](#3865)) ([f689297](f689297)) * **yellowpaper:** Logs ([#4016](#4016)) ([d734c79](d734c79)) * **yellowpaper:** Update AVM spec for with "daGasLeft", some cleanup ([#3956](#3956)) ([a9537fb](a9537fb)) </details> <details><summary>barretenberg.js: 0.18.0</summary> ## [0.18.0](barretenberg.js-v0.17.0...barretenberg.js-v0.18.0) (2024-01-16) ### Features * Bootstrap cache v2 ([#3876](#3876)) ([331598d](331598d)) ### Bug Fixes * Dont spam logs with yarn install ([#4027](#4027)) ([949c5ab](949c5ab)) </details> <details><summary>barretenberg: 0.18.0</summary> ## [0.18.0](barretenberg-v0.17.0...barretenberg-v0.18.0) (2024-01-16) ### ⚠ BREAKING CHANGES * Remove `Directive::Quotient` ([#4019](#4019)) * implement keccakf1600 in brillig ([#3914](#3914)) * add blake3 opcode to brillig ([#3913](#3913)) * Remove opcode supported from the backend ([#3889](#3889)) ### Features * Acir cleanup ([#3845](#3845)) ([390b84c](390b84c)) * Add ACIR opcodes for ECADD and ECDOUBLE ([#3878](#3878)) ([537630f](537630f)) * Add blake3 opcode to brillig ([#3913](#3913)) ([34fad0a](34fad0a)) * Bench bb in pr's, docker shell utils ([#3561](#3561)) ([5408919](5408919)) * Benchmark protogalaxy prover ([#3958](#3958)) ([5843722](5843722)) * Benchmarks for basic functionality and IPA improvements ([#4004](#4004)) ([fd1f619](fd1f619)) * Bootstrap cache v2 ([#3876](#3876)) ([331598d](331598d)) * Implement keccakf1600 in brillig ([#3914](#3914)) ([a182381](a182381)) * Parallel IPA ([#3882](#3882)) ([7002a33](7002a33)) * Pil lookups w/ xor table example ([#3880](#3880)) ([544d24e](544d24e)) * Poseidon2 stdlib impl ([#3551](#3551)) ([50b4a72](50b4a72)) * Protogalaxy Decider and complete folding tests ([#3657](#3657)) ([cfdaf9c](cfdaf9c)) * Relations vs widgets benchmarking ([#3931](#3931)) ([3af64ef](3af64ef)) * Remove opcode supported from the backend ([#3889](#3889)) ([1fd135c](1fd135c)) * Reorganize acir composer ([#3957](#3957)) ([e6232e8](e6232e8)) * Standalone calldata test ([#3842](#3842)) ([7353a35](7353a35)) ### Bug Fixes * Bb unnecessary env var ([#3901](#3901)) ([f127e5a](f127e5a)) ### Miscellaneous * Codegen acir opcodes after renaming arithmetic to assertzero ([#3896](#3896)) ([c710ce1](c710ce1)) * Document `witness_buf_to_witness_data` ([#3940](#3940)) ([fbaa726](fbaa726)) * Remove 'extern template's, expand macros ([#3953](#3953)) ([5fe9908](5fe9908)) * Remove `Directive::Quotient` ([#4019](#4019)) ([824d76f](824d76f)) * Reorganize benchmarks ([#3909](#3909)) ([730766b](730766b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.18.0</summary> ## [0.18.0](AztecProtocol/aztec-packages@aztec-packages-v0.17.0...aztec-packages-v0.18.0) (2024-01-16) ### ⚠ BREAKING CHANGES * Remove `Directive::Quotient` ([#4019](AztecProtocol/aztec-packages#4019)) * define key type in maps ([#3841](AztecProtocol/aztec-packages#3841)) * implement keccakf1600 in brillig ([#3914](AztecProtocol/aztec-packages#3914)) * add blake3 opcode to brillig ([#3913](AztecProtocol/aztec-packages#3913)) * Remove opcode supported from the backend ([#3889](AztecProtocol/aztec-packages#3889)) ### Features * `PartialStateReference` and `StateReference` structs ([#3827](AztecProtocol/aztec-packages#3827)) ([3ba0369](AztecProtocol/aztec-packages@3ba0369)) * `StateDiffHints` ([#3919](AztecProtocol/aztec-packages#3919)) ([8774795](AztecProtocol/aztec-packages@8774795)), closes [#3916](AztecProtocol/aztec-packages#3916) * Acir cleanup ([#3845](AztecProtocol/aztec-packages#3845)) ([390b84c](AztecProtocol/aztec-packages@390b84c)) * Add ACIR opcodes for ECADD and ECDOUBLE ([#3878](AztecProtocol/aztec-packages#3878)) ([537630f](AztecProtocol/aztec-packages@537630f)) * Add blake3 opcode to brillig ([#3913](AztecProtocol/aztec-packages#3913)) ([34fad0a](AztecProtocol/aztec-packages@34fad0a)) * Add data availability oracle ([#3897](AztecProtocol/aztec-packages#3897)) ([5441753](AztecProtocol/aztec-packages@5441753)), closes [#3890](AztecProtocol/aztec-packages#3890) * Add str support for args + add name/symbol/decimal to token ([#3862](AztecProtocol/aztec-packages#3862)) ([0bf5d8c](AztecProtocol/aztec-packages@0bf5d8c)) * Bench bb in pr's, docker shell utils ([#3561](AztecProtocol/aztec-packages#3561)) ([5408919](AztecProtocol/aztec-packages@5408919)) * Benchmark protogalaxy prover ([#3958](AztecProtocol/aztec-packages#3958)) ([5843722](AztecProtocol/aztec-packages@5843722)) * Benchmarks for basic functionality and IPA improvements ([#4004](AztecProtocol/aztec-packages#4004)) ([fd1f619](AztecProtocol/aztec-packages@fd1f619)) * Body hash as buffer in TS + minor cleanup ([#4012](AztecProtocol/aztec-packages#4012)) ([e28a6bf](AztecProtocol/aztec-packages@e28a6bf)) * Bootstrap cache v2 ([#3876](AztecProtocol/aztec-packages#3876)) ([331598d](AztecProtocol/aztec-packages@331598d)) * Counters in private functions ([#3850](AztecProtocol/aztec-packages#3850)) ([23bbf75](AztecProtocol/aztec-packages@23bbf75)) * Generate json blocks for tests ([#3923](AztecProtocol/aztec-packages#3923)) ([a09fd2a](AztecProtocol/aztec-packages@a09fd2a)) * Implement keccakf1600 in brillig ([#3914](AztecProtocol/aztec-packages#3914)) ([a182381](AztecProtocol/aztec-packages@a182381)) * Parallel IPA ([#3882](AztecProtocol/aztec-packages#3882)) ([7002a33](AztecProtocol/aztec-packages@7002a33)) * Pil lookups w/ xor table example ([#3880](AztecProtocol/aztec-packages#3880)) ([544d24e](AztecProtocol/aztec-packages@544d24e)) * Poseidon2 stdlib impl ([#3551](AztecProtocol/aztec-packages#3551)) ([50b4a72](AztecProtocol/aztec-packages@50b4a72)) * Protogalaxy Decider and complete folding tests ([#3657](AztecProtocol/aztec-packages#3657)) ([cfdaf9c](AztecProtocol/aztec-packages@cfdaf9c)) * Reexport `protocol_types` from `aztec-nr` ([#3926](AztecProtocol/aztec-packages#3926)) ([9bd22f7](AztecProtocol/aztec-packages@9bd22f7)) * Relations vs widgets benchmarking ([#3931](AztecProtocol/aztec-packages#3931)) ([3af64ef](AztecProtocol/aztec-packages@3af64ef)) * Remove opcode supported from the backend ([#3889](AztecProtocol/aztec-packages#3889)) ([1fd135c](AztecProtocol/aztec-packages@1fd135c)) * Reorganize acir composer ([#3957](AztecProtocol/aztec-packages#3957)) ([e6232e8](AztecProtocol/aztec-packages@e6232e8)) * Replace bitwise ORs in `U256:from_bytes32` with addition ([#3947](AztecProtocol/aztec-packages#3947)) ([efd7660](AztecProtocol/aztec-packages@efd7660)) * Standalone calldata test ([#3842](AztecProtocol/aztec-packages#3842)) ([7353a35](AztecProtocol/aztec-packages@7353a35)) * Sync with main noir repo ([#3939](AztecProtocol/aztec-packages#3939)) ([69c7e99](AztecProtocol/aztec-packages@69c7e99)) * Update noir ([#3979](AztecProtocol/aztec-packages#3979)) ([271de71](AztecProtocol/aztec-packages@271de71)) * Verify state hash is correct before publishing to L1 ([#3915](AztecProtocol/aztec-packages#3915)) ([a53c261](AztecProtocol/aztec-packages@a53c261)) ### Bug Fixes * **aztec-nr:** Broken nargo url ([#3925](AztecProtocol/aztec-packages#3925)) ([034bc30](AztecProtocol/aztec-packages@034bc30)) * Back out the buggy branch condition ([#3988](AztecProtocol/aztec-packages#3988)) ([9f61ed1](AztecProtocol/aztec-packages@9f61ed1)) * Bb unnecessary env var ([#3901](AztecProtocol/aztec-packages#3901)) ([f127e5a](AztecProtocol/aztec-packages@f127e5a)) * Broken links by paterson1 ([#3902](AztecProtocol/aztec-packages#3902)) ([6783aaa](AztecProtocol/aztec-packages@6783aaa)) * **cli:** Unbox command should run as release ([#3974](AztecProtocol/aztec-packages#3974)) ([80c3805](AztecProtocol/aztec-packages@80c3805)) * **cli:** Unbox should set up the accounts package ([#3972](AztecProtocol/aztec-packages#3972)) ([065e988](AztecProtocol/aztec-packages@065e988)) * Docusaurus start command ([#3968](AztecProtocol/aztec-packages#3968)) ([87c0b07](AztecProtocol/aztec-packages@87c0b07)) * Dont spam logs with yarn install ([#4027](AztecProtocol/aztec-packages#4027)) ([949c5ab](AztecProtocol/aztec-packages@949c5ab)) * Fix compilation of `token` box ([#3981](AztecProtocol/aztec-packages#3981)) ([0f994d0](AztecProtocol/aztec-packages@0f994d0)) * Mirror_noir_subrepo.yml erroring ([#3954](AztecProtocol/aztec-packages#3954)) ([2ac1b9c](AztecProtocol/aztec-packages@2ac1b9c)) * Quote the glob string for ignore branches for protocol-circuits-gate-diff ([#3990](AztecProtocol/aztec-packages#3990)) ([a43889d](AztecProtocol/aztec-packages@a43889d)) * Reprocess notes in pxe when a new contract is added ([#3867](AztecProtocol/aztec-packages#3867)) ([ccbff99](AztecProtocol/aztec-packages@ccbff99)) * Segment tree insertion stats by depth ([#4029](AztecProtocol/aztec-packages#4029)) ([2787bae](AztecProtocol/aztec-packages@2787bae)) * Store blockhash alongside blocks ([#3950](AztecProtocol/aztec-packages#3950)) ([12b07fa](AztecProtocol/aztec-packages@12b07fa)), closes [#3870](AztecProtocol/aztec-packages#3870) * Swap branch exclusion for release-please on report gates diff workflow ([#3994](AztecProtocol/aztec-packages#3994)) ([70b2ffd](AztecProtocol/aztec-packages@70b2ffd)) * Typos in authwit.md by czepluch ([#3921](AztecProtocol/aztec-packages#3921)) ([4b9d0f4](AztecProtocol/aztec-packages@4b9d0f4)) * Yellowpaper docusaurus start command ([#3969](AztecProtocol/aztec-packages#3969)) ([4977cbc](AztecProtocol/aztec-packages@4977cbc)) ### Miscellaneous * Add a link back to `aztec-packages` in noir sync PR ([#4018](AztecProtocol/aztec-packages#4018)) ([7d89f3b](AztecProtocol/aztec-packages@7d89f3b)) * Catch up note processors could be synced more efficiently ([#3933](AztecProtocol/aztec-packages#3933)) ([df54f33](AztecProtocol/aztec-packages@df54f33)) * **ci:** Require boxes CI to succeed ([#3983](AztecProtocol/aztec-packages#3983)) ([93cbea1](AztecProtocol/aztec-packages@93cbea1)) * Cleanup duplicated methods for structs after traits ([#3912](AztecProtocol/aztec-packages#3912)) ([60b59da](AztecProtocol/aztec-packages@60b59da)) * Cleanup sandbox dependent tests ([#3861](AztecProtocol/aztec-packages#3861)) ([158c5be](AztecProtocol/aztec-packages@158c5be)) * Codegen acir opcodes after renaming arithmetic to assertzero ([#3896](AztecProtocol/aztec-packages#3896)) ([c710ce1](AztecProtocol/aztec-packages@c710ce1)) * Define key type in maps ([#3841](AztecProtocol/aztec-packages#3841)) ([cf15adb](AztecProtocol/aztec-packages@cf15adb)) * Delete the compiler from `noir-compiler` ([#3959](AztecProtocol/aztec-packages#3959)) ([9aa0986](AztecProtocol/aztec-packages@9aa0986)) * Deploy canary release of bb.js to npm via CCI ([#3917](AztecProtocol/aztec-packages#3917)) ([bdeb10c](AztecProtocol/aztec-packages@bdeb10c)) * Do not fail jq dependencies check for package with no deps ([#3894](AztecProtocol/aztec-packages#3894)) ([22c65bf](AztecProtocol/aztec-packages@22c65bf)) * Do not pass redundant txNullifier when computing notes ([#3943](AztecProtocol/aztec-packages#3943)) ([9355cda](AztecProtocol/aztec-packages@9355cda)) * Do not run CCI on release-please branches ([#3984](AztecProtocol/aztec-packages#3984)) ([c38dbd2](AztecProtocol/aztec-packages@c38dbd2)) * **docs:** Fix ts code in token bridge tutorial ([#3888](AztecProtocol/aztec-packages#3888)) ([f53f8ed](AztecProtocol/aztec-packages@f53f8ed)) * **docs:** Move map keys to new release in migration guide ([#3977](AztecProtocol/aztec-packages#3977)) ([6356d94](AztecProtocol/aztec-packages@6356d94)) * **docs:** Update missing @aztec/accounts missing import in testing.md ([#3903](AztecProtocol/aztec-packages#3903)) ([755668a](AztecProtocol/aztec-packages@755668a)) * Document `witness_buf_to_witness_data` ([#3940](AztecProtocol/aztec-packages#3940)) ([fbaa726](AztecProtocol/aztec-packages@fbaa726)) * End to end test node & pxe persistence ([#3911](AztecProtocol/aztec-packages#3911)) ([6164ccd](AztecProtocol/aztec-packages@6164ccd)) * Enforce immutable yarn installs in CI ([#3964](AztecProtocol/aztec-packages#3964)) ([f3104ac](AztecProtocol/aztec-packages@f3104ac)) * Fix rust tests ([#3963](AztecProtocol/aztec-packages#3963)) ([a907c3b](AztecProtocol/aztec-packages@a907c3b)) * Fix sidebar index links ([#3942](AztecProtocol/aztec-packages#3942)) ([984f1f8](AztecProtocol/aztec-packages@984f1f8)) * Git subrepo commit (merge) noir ([#3955](AztecProtocol/aztec-packages#3955)) ([2c2bc69](AztecProtocol/aztec-packages@2c2bc69)) * Introduce EventSelector class ([#3960](AztecProtocol/aztec-packages#3960)) ([7315f2c](AztecProtocol/aztec-packages@7315f2c)) * Investigate P2P test ([#3929](AztecProtocol/aztec-packages#3929)) ([0fca2c4](AztecProtocol/aztec-packages@0fca2c4)) * Move types to circuit-types ([#3967](AztecProtocol/aztec-packages#3967)) ([f81b7c0](AztecProtocol/aztec-packages@f81b7c0)) * Persistence uses TokenContract ([#3930](AztecProtocol/aztec-packages#3930)) ([1a052c4](AztecProtocol/aztec-packages@1a052c4)) * Pull in noir from upstream ([#3904](AztecProtocol/aztec-packages#3904)) ([ab07e7e](AztecProtocol/aztec-packages@ab07e7e)) * Recreated types package without circuits.js dependency ([#3970](AztecProtocol/aztec-packages#3970)) ([fc1d539](AztecProtocol/aztec-packages@fc1d539)) * Refactor serialisation functions and sibling paths ([#3980](AztecProtocol/aztec-packages#3980)) ([1a936fc](AztecProtocol/aztec-packages@1a936fc)) * Remove 'extern template's, expand macros ([#3953](AztecProtocol/aztec-packages#3953)) ([5fe9908](AztecProtocol/aztec-packages@5fe9908)) * Remove `Directive::Quotient` ([#4019](AztecProtocol/aztec-packages#4019)) ([824d76f](AztecProtocol/aztec-packages@824d76f)) * Remove sandbox and cli npm pkgs ([#3567](AztecProtocol/aztec-packages#3567)) ([a8cf1bf](AztecProtocol/aztec-packages@a8cf1bf)) * Reorganize benchmarks ([#3909](AztecProtocol/aztec-packages#3909)) ([730766b](AztecProtocol/aztec-packages@730766b)) * Replace `AztecU128` with `U128` ([#3951](AztecProtocol/aztec-packages#3951)) ([e3b288d](AztecProtocol/aztec-packages@e3b288d)) * Replace relative paths to noir-protocol-circuits ([2c25f04](AztecProtocol/aztec-packages@2c25f04)) * Replace relative paths to noir-protocol-circuits ([0c8b770](AztecProtocol/aztec-packages@0c8b770)) * Replace relative paths to noir-protocol-circuits ([d3819ba](AztecProtocol/aztec-packages@d3819ba)) * Standardise toml parsers ([#3910](AztecProtocol/aztec-packages#3910)) ([963035f](AztecProtocol/aztec-packages@963035f)) * Sync noir ([#4025](AztecProtocol/aztec-packages#4025)) ([4e90d7b](AztecProtocol/aztec-packages@4e90d7b)) * Sync Noir repo ([#4020](AztecProtocol/aztec-packages#4020)) ([876603e](AztecProtocol/aztec-packages@876603e)) * **yellowpaper:** Cleanup avm sidebar, fix filename case ([#3952](AztecProtocol/aztec-packages#3952)) ([5211060](AztecProtocol/aztec-packages@5211060)) * Yp docs sidebar (with some auto-formatting) ([#3893](AztecProtocol/aztec-packages#3893)) ([f7b007a](AztecProtocol/aztec-packages@f7b007a)) ### Documentation * Noir git subrepo usage ([#3962](AztecProtocol/aztec-packages#3962)) ([2e4c9de](AztecProtocol/aztec-packages@2e4c9de)) * Streamlined pr template ([#3932](AztecProtocol/aztec-packages#3932)) ([5ec1559](AztecProtocol/aztec-packages@5ec1559)) * **yellowpaper:** Avm call pointers, bytecode lookups, circuit io ([#3898](AztecProtocol/aztec-packages#3898)) ([45e1ed2](AztecProtocol/aztec-packages@45e1ed2)) * **yellowpaper:** Avm circuit architecture ([#3934](AztecProtocol/aztec-packages#3934)) ([6aed1d0](AztecProtocol/aztec-packages@6aed1d0)) * **yellowpaper:** First draft of avm circuit memory ([#3865](AztecProtocol/aztec-packages#3865)) ([f689297](AztecProtocol/aztec-packages@f689297)) * **yellowpaper:** Logs ([#4016](AztecProtocol/aztec-packages#4016)) ([d734c79](AztecProtocol/aztec-packages@d734c79)) * **yellowpaper:** Update AVM spec for with "daGasLeft", some cleanup ([#3956](AztecProtocol/aztec-packages#3956)) ([a9537fb](AztecProtocol/aztec-packages@a9537fb)) </details> <details><summary>barretenberg.js: 0.18.0</summary> ## [0.18.0](AztecProtocol/aztec-packages@barretenberg.js-v0.17.0...barretenberg.js-v0.18.0) (2024-01-16) ### Features * Bootstrap cache v2 ([#3876](AztecProtocol/aztec-packages#3876)) ([331598d](AztecProtocol/aztec-packages@331598d)) ### Bug Fixes * Dont spam logs with yarn install ([#4027](AztecProtocol/aztec-packages#4027)) ([949c5ab](AztecProtocol/aztec-packages@949c5ab)) </details> <details><summary>barretenberg: 0.18.0</summary> ## [0.18.0](AztecProtocol/aztec-packages@barretenberg-v0.17.0...barretenberg-v0.18.0) (2024-01-16) ### ⚠ BREAKING CHANGES * Remove `Directive::Quotient` ([#4019](AztecProtocol/aztec-packages#4019)) * implement keccakf1600 in brillig ([#3914](AztecProtocol/aztec-packages#3914)) * add blake3 opcode to brillig ([#3913](AztecProtocol/aztec-packages#3913)) * Remove opcode supported from the backend ([#3889](AztecProtocol/aztec-packages#3889)) ### Features * Acir cleanup ([#3845](AztecProtocol/aztec-packages#3845)) ([390b84c](AztecProtocol/aztec-packages@390b84c)) * Add ACIR opcodes for ECADD and ECDOUBLE ([#3878](AztecProtocol/aztec-packages#3878)) ([537630f](AztecProtocol/aztec-packages@537630f)) * Add blake3 opcode to brillig ([#3913](AztecProtocol/aztec-packages#3913)) ([34fad0a](AztecProtocol/aztec-packages@34fad0a)) * Bench bb in pr's, docker shell utils ([#3561](AztecProtocol/aztec-packages#3561)) ([5408919](AztecProtocol/aztec-packages@5408919)) * Benchmark protogalaxy prover ([#3958](AztecProtocol/aztec-packages#3958)) ([5843722](AztecProtocol/aztec-packages@5843722)) * Benchmarks for basic functionality and IPA improvements ([#4004](AztecProtocol/aztec-packages#4004)) ([fd1f619](AztecProtocol/aztec-packages@fd1f619)) * Bootstrap cache v2 ([#3876](AztecProtocol/aztec-packages#3876)) ([331598d](AztecProtocol/aztec-packages@331598d)) * Implement keccakf1600 in brillig ([#3914](AztecProtocol/aztec-packages#3914)) ([a182381](AztecProtocol/aztec-packages@a182381)) * Parallel IPA ([#3882](AztecProtocol/aztec-packages#3882)) ([7002a33](AztecProtocol/aztec-packages@7002a33)) * Pil lookups w/ xor table example ([#3880](AztecProtocol/aztec-packages#3880)) ([544d24e](AztecProtocol/aztec-packages@544d24e)) * Poseidon2 stdlib impl ([#3551](AztecProtocol/aztec-packages#3551)) ([50b4a72](AztecProtocol/aztec-packages@50b4a72)) * Protogalaxy Decider and complete folding tests ([#3657](AztecProtocol/aztec-packages#3657)) ([cfdaf9c](AztecProtocol/aztec-packages@cfdaf9c)) * Relations vs widgets benchmarking ([#3931](AztecProtocol/aztec-packages#3931)) ([3af64ef](AztecProtocol/aztec-packages@3af64ef)) * Remove opcode supported from the backend ([#3889](AztecProtocol/aztec-packages#3889)) ([1fd135c](AztecProtocol/aztec-packages@1fd135c)) * Reorganize acir composer ([#3957](AztecProtocol/aztec-packages#3957)) ([e6232e8](AztecProtocol/aztec-packages@e6232e8)) * Standalone calldata test ([#3842](AztecProtocol/aztec-packages#3842)) ([7353a35](AztecProtocol/aztec-packages@7353a35)) ### Bug Fixes * Bb unnecessary env var ([#3901](AztecProtocol/aztec-packages#3901)) ([f127e5a](AztecProtocol/aztec-packages@f127e5a)) ### Miscellaneous * Codegen acir opcodes after renaming arithmetic to assertzero ([#3896](AztecProtocol/aztec-packages#3896)) ([c710ce1](AztecProtocol/aztec-packages@c710ce1)) * Document `witness_buf_to_witness_data` ([#3940](AztecProtocol/aztec-packages#3940)) ([fbaa726](AztecProtocol/aztec-packages@fbaa726)) * Remove 'extern template's, expand macros ([#3953](AztecProtocol/aztec-packages#3953)) ([5fe9908](AztecProtocol/aztec-packages@5fe9908)) * Remove `Directive::Quotient` ([#4019](AztecProtocol/aztec-packages#4019)) ([824d76f](AztecProtocol/aztec-packages@824d76f)) * Reorganize benchmarks ([#3909](AztecProtocol/aztec-packages#3909)) ([730766b](AztecProtocol/aztec-packages@730766b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR removed the assumption of some tests running against the sandbox. Only boxes and docs tests imply sandbox usage. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: Santiago Palladino <[email protected]>

PhilWindle added 4 commits January 5, 2024 17:20

Initial cleanup

b93d531

Formatting

db662e8

Formatting

7076ee6

Cleanup

3453dce

PhilWindle and others added 21 commits January 5, 2024 18:10

Fixes

a30be6a

Fixes

28a1ef5

Extract accounts out of aztecjs into new package and update imports

9231590

Remove unneeded types in package.common

e370f7b

Fix sample-dapp tests

431f72b

Remove web build from accounts package

ef4c2ba

Build web package specific for e2e tests

d8c2892

Fix package local json

3378e09

Order tsconfig refs

695bccc

Update readmes

1b0a10b

Format

b71c0e6

Fix links in docs

88fb559

Update docs content

2774060

Fix boxes and format

4504a69

Remove unused web build entrypoint for account package

867350a

Add accounts api reference to docsite

362f4d8

Fixes

b9bbe1f

Fixes

2d942fb

Fixes

74a2193

Fix

6fb4248

Fixes

e8c44ab

PhilWindle changed the title ~~chore: Cleanup tests~~ chore: Cleanup sandbox dependent tests Jan 5, 2024

PhilWindle marked this pull request as ready for review January 5, 2024 19:55

spalladino reviewed Jan 5, 2024

View reviewed changes

Fixes

74149e2

PhilWindle added 4 commits January 8, 2024 13:27

Formatting

9247064

Fixes

2b01828

Formatting

53ecc7c

Formatting

2e7d550

spalladino approved these changes Jan 8, 2024

View reviewed changes

PhilWindle added 10 commits January 8, 2024 21:52

More cleanup

3f68a96

Fixes

b5334bd

Another fix

c237ea1

More cleanup

b54ec49

Cleanup

1881d06

Formatting

0c3355c

Cleanup

0d36628

Fixes

b011582

More cleanup

224c50b

Merge branch 'master' into pw/cleanup-tests

7003e5a

spypsy reviewed Jan 9, 2024

View reviewed changes

PhilWindle added 5 commits January 9, 2024 11:37

Formatting

5a01b07

Fix

df057ed

Formatting

2cde2bd

Fixes

a3b13f1

Formatting

9a54b82

PhilWindle enabled auto-merge (squash) January 9, 2024 12:42

Merge branch 'master' into pw/cleanup-tests

bdaae06

PhilWindle merged commit 158c5be into master Jan 9, 2024
80 of 81 checks passed

PhilWindle deleted the pw/cleanup-tests branch January 9, 2024 13:19

AztecBot mentioned this pull request Jan 9, 2024

chore(master): Release 0.18.0 #3892

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Cleanup sandbox dependent tests #3861

chore: Cleanup sandbox dependent tests #3861

PhilWindle commented Jan 5, 2024 •

edited

Loading

AztecBot commented Jan 5, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

spalladino Jan 5, 2024

spalladino Jan 5, 2024

PhilWindle Jan 8, 2024

spalladino Jan 5, 2024

PhilWindle Jan 8, 2024 •

edited

Loading

spalladino Jan 8, 2024

spalladino Jan 5, 2024

PhilWindle Jan 8, 2024

spalladino Jan 5, 2024

PhilWindle Jan 6, 2024

spalladino Jan 5, 2024

PhilWindle Jan 8, 2024

spalladino Jan 8, 2024

PhilWindle Jan 9, 2024

spalladino Jan 8, 2024

spypsy Jan 9, 2024

PhilWindle Jan 9, 2024

	console.log(`RPC URL ${pxeURL}`);
	console.log(`RPC URL ${rpcUrl}`);

chore: Cleanup sandbox dependent tests #3861

chore: Cleanup sandbox dependent tests #3861

Conversation

PhilWindle commented Jan 5, 2024 • edited Loading

Checklist:

AztecBot commented Jan 5, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PhilWindle Jan 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PhilWindle commented Jan 5, 2024 •

edited

Loading

AztecBot commented Jan 5, 2024 •

edited

Loading

PhilWindle Jan 8, 2024 •

edited

Loading