chore!: define key type in maps

[Thunkar]

Closes #2787

Unfortunately key type with a ToField trait binding is only defined in the .at method, due to this blocker:

noir-lang/noir#3954

[AztecBot]

Benchmark results

Metrics with a significant change:

• node_database_size_in_bytes (10): 3,719,392 (-30%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 1fd135cb and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,780	868,292	3,449,576
l1_rollup_execution_gas	936,113	3,970,955	24,793,301
l2_block_processing_time_in_ms	1,346 (-11%)	5,129	20,939 (-1%)
note_successful_decrypting_time_in_ms	332 (-4%)	1,017 (+2%)	3,698 (-2%)
note_trial_decrypting_time_in_ms	45.8 (-18%)	38.2 (-69%)	190 (+36%)
l2_block_building_time_in_ms	15,044	59,800	239,993
l2_block_rollup_simulation_time_in_ms	10,688	42,618	171,279
l2_block_public_tx_process_time_in_ms	4,322 (-1%)	17,084	68,290

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,327 (+2%)	29,003
note_history_successful_decrypting_time_in_ms	2,388 (+1%)	4,662 (-4%)
note_history_trial_decrypting_time_in_ms	79.6 (+1%)	158 (-17%)
node_database_size_in_bytes	3,618,534	⚠️ 3,719,392 (-30%)
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	211	44,709	25,561
private-kernel-ordering	138	30,953	14,809
base-rollup	1,082	128,374	881
root-rollup	82.6	4,088	889
private-kernel-inner	288	71,236	25,561
public-kernel-private-input	202	31,891	25,561
public-kernel-non-first-iteration	201	31,933	25,561
merge-rollup	9.70 (-1%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_ms	11.1 (-2%)	89.3 (+1%)	15.2 (+8%)	17.8	23.9	49.9 (-1%)	88.3 (-1%)	242 (-1%)	469	908	3,552 (-1%)
batch_insert_into_indexed_tree_ms	N/A	N/A	N/A	64.1 (-1%)	N/A	59.3 (-1%)	110 (-1%)	358 (-1%)	730 (-2%)	1,411	5,708 (-1%)

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,487	31,903

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	345	966

Metric	1 public data writes
tx_sequencer_processing_time_ms	530

[benesjan]

Beautiful change 😍