Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AuthWit): Allow generating authwits on the fly #3745

Open
Tracked by #5759 ...
spalladino opened this issue Dec 19, 2023 · 3 comments
Open
Tracked by #5759 ...

feat(AuthWit): Allow generating authwits on the fly #3745

spalladino opened this issue Dec 19, 2023 · 3 comments
Labels
T-feedback Type: recording user feedback team-fairies Nico's team

Comments

@spalladino
Copy link
Collaborator

spalladino commented Dec 19, 2023

In complex executions it's difficult for the app to foresee the exact authwit requests that need to be added to the pxe before simulating execution. It's particularly difficult if the authwit request includes a random element.

Until we implement something like #9133, it may be useful to allow devs to sign authwits on the fly as they are requested to the pxe's oracle.

Note that this may be difficult to implement today, since the pxe today sits behind a json rpc interface, and has no way to call back into the client. In an actual production setup, the pxe would be integrated into the wallet software, and it'd be the wallet that implements this hook and not aztec.js.

Requested by Wonderland

@spalladino spalladino added the T-feedback Type: recording user feedback label Dec 19, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 19, 2023
@LHerskind LHerskind changed the title Allow generating authwits on the fly from the PXE feat(AuthWit): Allow generating authwits on the fly from the PXE Mar 8, 2024
@LHerskind
Copy link
Contributor

We can introduce a oracle that makes a call out, requesting for a structured message (#5075) to be signed by the PXE. For testing, could be possible to just have the PXE blindly sign what it is asked, but for user execution it could make a call to the user's wallet, allowing them to sign the request or deny it and make the transaction fail.

Should help on our issue of currently requiring clairvoyant code.

@LHerskind LHerskind added this to the Developer Facing Aztec.nr milestone Mar 8, 2024
@LHerskind LHerskind changed the title feat(AuthWit): Allow generating authwits on the fly from the PXE feat(AuthWit): Allow generating authwits on the fly Mar 11, 2024
@LHerskind LHerskind self-assigned this Mar 11, 2024
@LHerskind
Copy link
Contributor

Since we have more pressing matters and this is mainly a nice to have, I'm unassigning myself from this task.

@LHerskind LHerskind removed their assignment Apr 22, 2024
@iAmMichaelConnor iAmMichaelConnor removed this from the Developer Facing Aztec.nr milestone Oct 9, 2024
This was referenced Oct 10, 2024
@nventuro
Copy link
Contributor

but for user execution it could make a call to the user's wallet, allowing them to sign the request or deny it and make the transaction fail.

The big issue here is how do we reach back to the wallet, since it is the wallet that has called into PXE via json-rpc. Is the wallet e.g. listening at some endpoint for singing requests?

@nventuro nventuro added the team-fairies Nico's team label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feedback Type: recording user feedback team-fairies Nico's team
Projects
Status: Todo
Development

No branches or pull requests

4 participants