Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky e2e-p2p test #3654

Closed
benesjan opened this issue Dec 12, 2023 · 0 comments · Fixed by #3831
Closed

Flaky e2e-p2p test #3654

benesjan opened this issue Dec 12, 2023 · 0 comments · Fixed by #3831

Comments

@benesjan
Copy link
Contributor

benesjan commented Dec 12, 2023 •
edited
Loading

Plenty of the times the test randomly fails with:

aztec:sequencer:publisher ERROR Rollup publish failed: TransactionExecutionError Nonce provided for the transaction is lower than the current nonce of the account.

This should be fixed.

E.g.:
https://app.circleci.com/pipelines/github/AztecProtocol/aztec-packages/18626/workflows/583cce6d-44c4-494a-9667-57b26a93d169/jobs/828692

https://app.circleci.com/pipelines/github/AztecProtocol/aztec-packages/19715/workflows/86a890a8-e0c9-4b1f-9779-6b656577e116/jobs/885167/parallel-runs/0/steps/0-103
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 12, 2023
@benesjan benesjan mentioned this issue Dec 12, 2023
Closed
@benesjan benesjan mentioned this issue Jan 4, 2024
Merged
4 tasks
benesjan added a commit that referenced this issue Jan 4, 2024
@benesjan
fix: flaky e2e-p2p test (#3831)
5b1e9f2 
Fixes #3654

**Note**: Lasse had a good hunch that it's most likely caused by
different nodes using the same l1 publisher private key. This PR changes
this and uses different accounts for different nodes. I am quite
confident that that is the culprit so I will close the issue.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 4, 2024
Maddiaa0 pushed a commit that referenced this issue Jan 8, 2024
@benesjan @Maddiaa0
fix: flaky e2e-p2p test (#3831)
b077e1c 
Fixes #3654

**Note**: Lasse had a good hunch that it's most likely caused by
different nodes using the same l1 publisher private key. This PR changes
this and uses different accounts for different nodes. I am quite
confident that that is the culprit so I will close the issue.
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@benesjan
fix: flaky e2e-p2p test (AztecProtocol#3831)
71a4454 
Fixes AztecProtocol#3654

**Note**: Lasse had a good hunch that it's most likely caused by
different nodes using the same l1 publisher private key. This PR changes
this and uses different accounts for different nodes. I am quite
confident that that is the culprit so I will close the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky e2e-p2p test AztecProtocol/aztec-packages
1 participant
@benesjan