Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm release of l1-contracts #3571

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fix: npm release of l1-contracts #3571

merged 4 commits into from
Dec 5, 2023

Conversation

rahul-kothari
Copy link
Contributor

release failed because l1-contracts doesn't have an image anymore

@rahul-kothari rahul-kothari requested review from charlielye and spypsy and removed request for charlielye December 5, 2023 13:52
@AztecBot
Copy link
Collaborator

AztecBot commented Dec 5, 2023

Benchmark results

Metrics with a significant change:

  • node_database_size_in_bytes (5): 2,791,689 (-23%)
  • node_database_size_in_bytes (10): 5,025,544 (+28%)
  • note_trial_decrypting_time_in_ms (32): 87.1 (+77%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 63b9cdc5 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,924 868,268 3,449,348
l1_rollup_execution_gas 842,011 3,595,376 22,204,717
l2_block_processing_time_in_ms 2,263 (+2%) 8,571 (+1%) 35,886 (+2%)
note_successful_decrypting_time_in_ms 318 960 (+4%) 3,455 (+3%)
note_trial_decrypting_time_in_ms 30.6 (+21%) ⚠️ 87.1 (+77%) 199 (-2%)
l2_block_building_time_in_ms 20,481 (+2%) 81,526 (+2%) 328,062 (+2%)
l2_block_rollup_simulation_time_in_ms 16,910 (+2%) 67,466 (+2%) 271,468 (+2%)
l2_block_public_tx_process_time_in_ms 3,522 (+1%) 13,909 56,035 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 24,523 (-1%) 47,110 (-1%)
note_history_successful_decrypting_time_in_ms 2,141 (-1%) 4,157 (-2%)
note_history_trial_decrypting_time_in_ms 163 (+1%) 232
node_database_size_in_bytes ⚠️ 2,791,689 (-23%) ⚠️ 5,025,544 (+28%)
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 200 (+1%) 43,109 20,441
private-kernel-ordering 115 25,833 9,689
base-rollup 2,957 664,108 (-1%) 873
root-rollup 89.8 (+4%) 4,072 881
private-kernel-inner 260 64,516 20,441
public-kernel-private-input 172 (+1%) 25,203 20,441
public-kernel-non-first-iteration 168 25,245 20,441
merge-rollup 11.0 (+1%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 10,323 25,938

@rahul-kothari rahul-kothari merged commit 487419b into master Dec 5, 2023
82 checks passed
@rahul-kothari rahul-kothari deleted the rk/fix_release branch December 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants