chore: remove sandbox and cli npm pkgs

[rahul-kothari]

Removes publishing of sandbox and cli npm packages
Also removes its references from the code (docs updates were already done)

1. Do we think we should wait a bit before completely nuking the npm section of the aztec-cli script? Currently i have just added deprecation messages
2. I couldn't remove @aztec/cli npm package from end-to-end because it uses getProgram(). Lmk if anyone has any good ideas

[AztecBot]

Benchmark results

Metrics with a significant change:

• l2_block_processing_time_in_ms (8): 1,562 (+18%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit fc1d5399 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	220,968	866,336	3,447,764
l1_rollup_execution_gas	934,112	3,968,810	24,791,300
l2_block_processing_time_in_ms	⚠️ 1,562 (+18%)	5,103	21,053 (-1%)
note_successful_decrypting_time_in_ms	307	942 (+1%)	3,367 (-1%)
note_trial_decrypting_time_in_ms	19.0 (+3%)	67.4 (+17%)	135 (+1%)
l2_block_building_time_in_ms	14,917	59,311	237,654 (-1%)
l2_block_rollup_simulation_time_in_ms	10,532	41,987	168,705
l2_block_public_tx_process_time_in_ms	4,353	17,246	68,677

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,291 (+1%)	29,310 (+1%)
note_history_successful_decrypting_time_in_ms	2,233 (+2%)	4,373 (+2%)
note_history_trial_decrypting_time_in_ms	140 (+18%)	185 (-3%)
node_database_size_in_bytes	3,625,752	3,734,396
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	214	44,681	25,561
private-kernel-ordering	165	43,753	14,809
base-rollup	1,069	128,338	881
root-rollup	81.2	4,088	709
private-kernel-inner	291	71,208	25,561
public-kernel-private-input	206	31,863	25,561
public-kernel-non-first-iteration	203	31,905	25,561
merge-rollup	8.43	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_ms	11.2	87.8	13.3 (-1%)	18.0	25.1 (+5%)	49.9	88.9 (+1%)	242	471 (+1%)	912	3,552
batch_insert_into_indexed_tree_ms	N/A	N/A	N/A	65.0 (+1%)	N/A	59.9 (+1%)	110 (-7%)	364 (+1%)	736 (+1%)	1,402	5,568 (-3%)

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,224

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	372	1,084

Metric	1 public data writes
tx_sequencer_processing_time_ms	537

[alexghr]

Update the aztec-cli update command

I have done the following changes to aztec-cli update:

1. It no longer fails if it doesn't detect package.json. So it can now be used to update contracts on their own aztec-cli update --contract path/to/some/folder
2. Instead of looking for the latest @aztec/aztec-sandbox, it now looks for the latest @aztec/aztec.js.
3. It checks if sandbox is running. If it is, it logs to the console if the versions don't match. If sandbox is not running it prints a reminder to update and links to docker update instructions and continues the update process.
4. It looks in package.json for @aztec/aztec-sandbox and @aztec/cli and if detected prints a warning. It doesn't prevent the update though.

I'm considering dropping the check in step 3 and always print the docker update instructions. If sandbox isn't running it delays the whole command by ~5-6 seconds while it tries to connect to a server that's not running.

Make changes to the bash script

Not needed anymore as we have an aztec-up command to manage the docker images as of #3617

[rahul-kothari]

@alexghr responding to your comment:

• 1/2 -> makes sense
• 3 -> makes sense to skip. PS - the docker update insutrctions should simply be aztec-up !!!

[rahul-kothari]

@spypsy do you know if this is safe to do?

[alexghr]

The cli Docker image builds on top of Dockerfile.prod so removing this would break aztec-cli.

[alexghr]

I think the changes to Dockerfile.prod need to be reverted since they'd break aztec-cli and aztec-sandbox images.

I think it might be worth adding @aztec/cli and @aztec/aztec-sandbox to this list in the CLI so devs are notified of the deprecation.

aztec-packages/yarn-project/cli/src/update/npm.ts

Lines 12 to 19 in 0fca2c4

	const deprecatedNpmPackages = new Set<string>([]);
	const npmDeprecationMessage = `
	The following packages have been deprecated and will no longer be updated on the npm registry:
	${Array.from(deprecatedNpmPackages)
	.map(pkg => ` - ${pkg}`)
	.join('\n')}
	Remove them from package.json
	`;

[alexghr]

The cli Docker image builds on top of Dockerfile.prod so removing this would break aztec-cli.

[alexghr]

Since the move to install.aztec.network in 0.17.0 this script isn't downloaded by new devs anymore and should be safe to delete (new installs are using aztec-up/bin/aztec-cli)

[alexghr]

I think we should also mark the cli and sandbox packages as deprecated on npmjs.com.

https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions

[rahul-kothari]

@alexghr deprecated on npmjs.com - https://www.npmjs.com/package/@aztec/aztec-sandbox?activeTab=versions

[benesjan]

Can you please make the tests pass first?

[alexghr]

I think a box was refercing one of bash wrappers for the cli 😟

[rahul-kothari]

fixed!

[benesjan]

Looks good to me but I am a bit distanced from the devops now so pls wait for someone like Alex to tell you it doesn't break something.

[alexghr]

Looks great!