feat: throw compile time error if contract has too many fns

[rahul-kothari]

fix #3500

Contracts can be compiled using nargo and nargo-wasm. So either we place compile time checks in aztec-nr or in noir-compiler. I have done it in later - specifically when we generate contract artifacts since that is the earliest function used by both noir-wasm + nargo.

Let me know if there is a better place to add the check 🤷

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
vite	4.4.8	eval, network, filesystem, shell, environment	+0	3.33 MB	vitebot
lodash.upperfirst	4.3.1	None	+0	11.4 kB	jdalton
react-markdown	6.0.0	None	+0	223 kB	wooorm

[benesjan]

Looks good

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_history_trial_decrypting_time_in_ms (10): 384 (+69%)
• note_trial_decrypting_time_in_ms (8): 35.1 (+45%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit ebdeea3f and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,912	868,148	3,449,312
l1_rollup_execution_gas	841,999	3,595,256	22,204,681
l2_block_processing_time_in_ms	2,198	8,624	35,786 (+1%)
note_successful_decrypting_time_in_ms	317 (+1%)	933 (+1%)	3,583 (+7%)
note_trial_decrypting_time_in_ms	⚠️ 35.1 (+45%)	59.2 (+9%)	202 (+1%)
l2_block_building_time_in_ms	20,372 (-1%)	81,182	324,924
l2_block_rollup_simulation_time_in_ms	16,809 (-1%)	67,210	268,777
l2_block_public_tx_process_time_in_ms	3,515	13,822	55,594

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	24,657 (+1%)	47,602
note_history_successful_decrypting_time_in_ms	2,154 (+1%)	4,392 (+6%)
note_history_trial_decrypting_time_in_ms	162 (-1%)	⚠️ 384 (+69%)
node_database_size_in_bytes	2,795,096	5,019,631
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	199 (-3%)	43,109	20,441
private-kernel-ordering	115 (-4%)	25,833	9,689
base-rollup	2,956 (-3%)	664,108	873
root-rollup	95.8 (+8%)	4,072	1,097
private-kernel-inner	260 (-1%)	64,516	20,441
public-kernel-private-input	171 (-1%)	25,203	20,441
public-kernel-non-first-iteration	168 (-2%)	25,245	20,441
merge-rollup	10.8 (-1%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	10,323	25,938